Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show suggest widget on trigger characters #175656

Closed
isidorn opened this issue Feb 28, 2023 · 1 comment · Fixed by #175677
Closed

Show suggest widget on trigger characters #175656

isidorn opened this issue Feb 28, 2023 · 1 comment · Fixed by #175677
Assignees
Labels
inline-completions insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 28, 2023

Refs: #131940

Let's change the default of
"editor.inlineSuggest.allowSuggestOnTriggerCharacters": true

Let's keep "editor.inlineSuggest.allowQuickSuggestions": false

After we do that let's double check if Copilot is returning null when we ask them for inline completions after a focused suggest item changes.

@isidorn isidorn added this to the March 2023 milestone Feb 28, 2023
hediet added a commit that referenced this issue Feb 28, 2023
@hediet
Copy link
Member

hediet commented Feb 28, 2023

After we do that let's double check if Copilot is returning null when we ask them for inline completions after a focused suggest item changes.

I just checked, this seems to be the case.

hediet added a commit that referenced this issue Feb 28, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
inline-completions insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants