Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Open on vscode.dev from the branch picker #176333

Closed
joyceerhl opened this issue Mar 7, 2023 · 2 comments · Fixed by #181549
Closed

Support Open on vscode.dev from the branch picker #176333

joyceerhl opened this issue Mar 7, 2023 · 2 comments · Fixed by #181549
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Mar 7, 2023

In #175676, we're adding the ability to checkout a PR on vscode.dev in addition to being able to checkout locally. The motivation for this is to allow reviewing PRs in the VS Code UI and benefit from multifile viewing/editing and workbench customizations in VS Code without blowing away your local checkout.

For similar reasons, it would be helpful to support opening a branch or tag on vscode.dev via the ref picker, e.g. if you want to view the state of the world at a particular ref and compare it side by side to a PR that you're working on locally.

This is pretty straightforward to implement for Remote Repos. Unfortunately one challenge for the deskop git extension is that today we only support viewing GitHub and Azure Repos repositories in vscode.dev, while the ref picker from the desktop git extension doesn't know about vscode.dev at the moment. We do have the GitHub remote source provider from the builtin GitHub extension which is capable of enriching the options we offer in the quickpick. I'm envisioning a ${globe} quickpick item button which would directly open the branch on vscode.dev if we support opening that provider type and if the branch is already published to a remote of a supported provider type.

@joyceerhl joyceerhl added the feature-request Request for new features or functionality label Mar 7, 2023
@joyceerhl joyceerhl added this to the March 2023 milestone Mar 7, 2023
@lszomoru lszomoru modified the milestones: March 2023, April 2023 Mar 20, 2023
@lszomoru lszomoru modified the milestones: April 2023, May 2023 Apr 26, 2023
@lszomoru
Copy link
Member

lszomoru commented May 3, 2023

@joyceerhl, is this something that you would like to stab at? Let me know if you need any help from me. Thanks!

@joyceerhl
Copy link
Contributor Author

joyceerhl commented May 4, 2023

@lszomoru yes, it would require a new api for the Git Base extension that is implemented by the GitHub extension. I can send a PR.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants