Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate detecting slow network connections #178553

Closed
bpasero opened this issue Mar 29, 2023 · 3 comments · Fixed by #182653
Closed

Investigate detecting slow network connections #178553

bpasero opened this issue Mar 29, 2023 · 3 comments · Fixed by #182653
Assignees
Labels
on-testplan plan-item VS Code - planned item for upcoming remote Remote system operations issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 29, 2023

  • consider to track response times between client and server
  • consider to show an affordance to the user when we detect slow network connection
@bpasero bpasero added plan-item VS Code - planned item for upcoming remote Remote system operations issues labels Mar 29, 2023
@bpasero bpasero added this to the April 2023 milestone Mar 29, 2023
@bpasero bpasero self-assigned this Mar 29, 2023
@bpasero bpasero removed this from the April 2023 milestone Apr 25, 2023
@bpasero
Copy link
Member Author

bpasero commented May 16, 2023

What we have today for indicate connection state

Remote Indicator:

image

image

image

image

Status Bar (web only):

image

Ideas for slow connection indicator

image

image

image

@bpasero bpasero added this to the May 2023 milestone May 16, 2023
@bpasero bpasero linked a pull request May 16, 2023 that will close this issue
@bpasero
Copy link
Member Author

bpasero commented May 17, 2023

Feedback from standup:

  • the threshold should be more clever
    • take the base latency into account, a user might have a slow network connection
    • take an upper maximum as a hardcoded value still
  • the latency should be in the issue reporter as data for us to see
  • latency information should go into the hover
  • it should work even with a custom indicator (Codespaces)
  • offline indication should move into indicator
  • color change only when latency is severe
  • remote icon change as subtle indicator?

@bpasero
Copy link
Member Author

bpasero commented May 17, 2023

UX Call feedback:

  • could we use something similar as the language status indicator
  • should not be too annoying when the modes change
  • red color suggests I can do something about it but what to do when latency is high?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-testplan plan-item VS Code - planned item for upcoming remote Remote system operations issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants