Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'Connect To Tunnel' on Welcome page in vscode.dev #179687

Closed
aeschli opened this issue Apr 11, 2023 · 9 comments
Closed

Show 'Connect To Tunnel' on Welcome page in vscode.dev #179687

aeschli opened this issue Apr 11, 2023 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 11, 2023

`Connect To Tunnel... should be prominently on the https://vscode.dev/ welcome page.

We want to explore if it's even possible to show the available tunnel names (if logged in)

@bhavyaus
Copy link
Collaborator

bhavyaus commented May 11, 2023

We now display "Connect via Remote Tunnels" in the start list entry on insiders.vscode.dev. It displays the list of existing tunnel options if signed in.

@bhavyaus
Copy link
Collaborator

We want to explore if it's even possible to show the available tunnel names (if logged in)

Once a workspace has been opened via tunnel, it would show up in the Recents list anyway and would be accessible from the Welcome Page. Should we still consider adding quick links to the existing remote tunnel connections? If yes, we could consider displaying existing tunnels under the Recents tab. We would need to ensure we pick the most recently used tunnels (or some other criteria) to only display a pre-determined number of tunnels in the list.

I also considered adding a new Connections list on the Welcome page to display remote connection links, but I worry that the welcome page might become too cluttered (with the addition of featured extension)

@aeschli
Copy link
Contributor Author

aeschli commented May 11, 2023

Thanks for adding Connect via Remote Tunnels, that's great.
What about naming it Open Tunnel... (to match the other open command) or Connect to Tunnel.. (to match the name of the command in the remote menu)

@aeschli
Copy link
Contributor Author

aeschli commented May 11, 2023

I was thinking that after the Connect to Tunnel... link we could show a list of tunnel names, e.g. 'Office-PC', 'Surface'.
Should not be more than 2 or 3 entries, anly only the open ones.

Connect to Tunnel... Office-PC Surface

Listing them in Recent would also work, but it's not exactly a recent entry

It was just an idea, of course it's not fitting right in the current getting started framework.

@bhavyaus
Copy link
Collaborator

I'll rename the command to Open Tunnel... as you suggested.
We could track usage of the command for now and later decide if it would be worthwhile to consider showing other remotes? (not just open tunnels) on the welcome page. For now, the list of available tunnels and their status is only one click away from the welcome page.
image

@aeschli
Copy link
Contributor Author

aeschli commented May 12, 2023

We could track usage of the command for now and later decide if it would be worthwhile to consider showing other remotes? (not just open tunnels) on the welcome page.

Sounds good! IMO we want to keep the open list short and focus on the command that are most useful on the given platform. For the web that's open a tunnel or a remote repo.

@aeschli
Copy link
Contributor Author

aeschli commented May 12, 2023

BTW, the welcome page now has hardcoded knowledge about the remote hub and tunnels extensions. It would be better if the list of additional open entries comes from product.json. Other products that are based on code oss might not want such open commands.

I think with such a list (label, command id), you can also avoid special handling for the tunnel extension in remoteStartEntry

@aeschli aeschli changed the title Show existing tunnels on Welcome page in vscode.dev Show 'Connect To Tunnel' on Welcome page in vscode.dev May 15, 2023
@bhavyaus
Copy link
Collaborator

BTW, the welcome page now has hardcoded knowledge about the remote hub and tunnels extensions. It would be better if the list of additional open entries comes from product.json. Other products that are based on code oss might not want such open commands.

I think with such a list (label, command id), you can also avoid special handling for the tunnel extension in remoteStartEntry

Labels coming from product.json would not be localized. I'll create a debt item to have it be setup for localization before refactoring since the remoteHub command and labels have existed in OSS for a while and I don't want to break that localization

@aeschli
Copy link
Contributor Author

aeschli commented May 29, 2023

Closing as fixed

@aeschli aeschli closed this as completed May 29, 2023
@bhavyaus bhavyaus added the feature-request Request for new features or functionality label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants