Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: dirty notebook working copy data loss prevention #180767

Closed
2 tasks done
rebornix opened this issue Apr 24, 2023 · 1 comment
Closed
2 tasks done

Test: dirty notebook working copy data loss prevention #180767

rebornix opened this issue Apr 24, 2023 · 1 comment

Comments

@rebornix
Copy link
Member

rebornix commented Apr 24, 2023

Refs: #179224

Complexity: 4

Authors: @rebornix @bpasero

Create Issue


Summary:

We now stopped disposing dirty notebook working copies to avoid data loss. Previously it happened when extension host goes down or restarts, and we will immediately try to save or dispose working copies, and they would throw exceptions since the serializer for the working copies are gone.

Now the experience has been improved:

Steps to Test:

ipynb

  • Create a new ipynb notebook
  • Turn off auto save, make the document dirty
  • Trigger EH restart, there are two ways
    • Switch to a new Profile
    • Kill the EH process through Process Explorer (or command line, task manager, etc)
  • Now test
    • After the profile switching or EH restart, you can switch between editor tabs
      • If the notebook editor doesn't open, you should see actions on the editor view, which guide you through how to install/enable missing extension or save the backups
    • Saving should work

github-issues

  • Install GitHub Issues Notebook extension and create a new github-issues notebook
  • Turn off auto save, make the document dirty
  • Switch to a new Profile without the GitHub Issue Notebook extension
  • Now test
    • After the profile switching , you can switch between editor tabs
      • If the notebook editor doesn't open, you should see actions on the editor view, which guide you through how to install/enable missing extension or save the backups
    • After the profile switching, reload the window immediately, test if the warning/error actions on the editor view gives you clear guidance
@joyceerhl
Copy link
Contributor

Nice! 👏

@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants