Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improove accessibility in diff editor #184229

Closed
3 of 4 tasks
balajip881 opened this issue Jun 3, 2023 · 3 comments
Closed
3 of 4 tasks

Improove accessibility in diff editor #184229

balajip881 opened this issue Jun 3, 2023 · 3 comments
Assignees
@hediet @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues
Milestone
Backlog

Comments

@balajip881
Copy link

balajip881 commented Jun 3, 2023 •
edited by hediet
Loading

For screen reader users,
After opening diff editor between old file and new file, pressing f7 opens patch view.
pressing enter on added lines takes me to new file
feature request :
@tamuratak
Copy link
Contributor

@hediet , seems related to #184164

@meganrogge meganrogge assigned hediet and unassigned meganrogge Jun 4, 2023
@hediet hediet added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues labels Jun 5, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Jun 5, 2023
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@hediet hediet mentioned this issue Jul 5, 2023
Closed
@hediet hediet modified the milestones: Backlog Candidates, Backlog Jul 5, 2023
@hediet hediet mentioned this issue Jul 18, 2023
Merged
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Rewrites accessible diff viewer (formerly called difference review)
d8c48c7 
Fixes #186420, Adresses #184229
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Rewrites accessible diff viewer (formerly called difference review)
c045c88 
Fixes #186420, Adresses #184229
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Rewrites accessible diff viewer (formerly called difference review) (#…
9f6ecfd 
…188165)

* Rewrites accessible diff viewer (formerly called difference review)
Fixes #186420, Adresses #184229

* Fixes CI.

* Fixes bug
hediet added a commit that referenced this issue Jul 18, 2023
@hediet
Rewrites accessible diff viewer (formerly called difference review)
38b3e89 
Fixes #186420, Adresses #184229
@hediet
Copy link
Member

hediet commented Jul 19, 2023

currently in patch diff editor view, navigation by character and word is not possible. provide these functionalites ASAP.

Duplicate of #166472

I created issues for the other feature requests, thus closing this one.

@hediet hediet closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2023
@hediet hediet removed the feature-request Request for new features or functionality label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@hediet @tamuratak @meganrogge @balajip881 @VSCodeTriageBot