Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebooks should obey files.trimTrailingWhitespace rule #190018

Closed
phil-chp opened this issue Aug 9, 2023 · 1 comment
Closed

Jupyter notebooks should obey files.trimTrailingWhitespace rule #190018

phil-chp opened this issue Aug 9, 2023 · 1 comment
Assignees

Comments

@phil-chp
Copy link

phil-chp commented Aug 9, 2023

Hello!

This issue has in fact already been discussed over a year ago: #151982, but didn't get enough traction, so I'm trying again.

I understand how this feature would have been missed, but the fact that I'm able to open the command palette and execute manually Trim Trailing Whitespace indicated this is a sort of bug.

So the idea is that when we have trailing whitespace characters in a Jupyter Notebook, and in our VScode settings we have any of the following rules:

{
    "files.trimTrailingWhitespace": true,
    "files.trimFinalNewlines": true,
    "files.insertFinalNewline": true,
}

These rules should apply to the Notebook, but this doesn't work.

@phil-chp phil-chp changed the title Jupyter notebooks, should obey files.trimTrailingWhitespace rule Jupyter notebooks should obey files.trimTrailingWhitespace rule Aug 9, 2023
@rebornix
Copy link
Member

This is a duplicate of #181905 and we have it on our iteration plan now.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants