Broken shader compilation with mesa update #190437
Comments
|
1.82 updated to Electron 25 and doesn't work on older OS. |
|
@lorand-horvath, I'm using cpe:/o:opensuse:tumbleweed:20230813, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using https://en.opensuse.org/SDB:KDE_repositories#Adding_these_repos_to_an_existing_installation which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at https://github.com/electron/electron/issues/new?assignees=&labels=bug+%3Abeetle%3A&projects=electron%2F90&template=bug_report.yml&title=%5BBug%5D%3A+? |
|
@RokeJulianLockhart Oh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help > Toggle Developer Tools bringing up? |
|
@lorand-horvath, #190437 (comment)
No problem. Thanks. Apologies for being curt.
# Start-Transcript -Append -IncludeInvocationHeader # Using `script -a -c 'pwsh-preview'` instead.
sudo zypper refresh && `
sudo zypper remove code-insiders && `
sudo zypper install code-insiders && `
code-insiders
Appears that it's reproducible. code-insiders --verbose |
|
Very strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. |
|
@lorand-horvath, does the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me. |
|
@RokeJulianLockhart I see many GPU-related errors, such as: Found these: |
This comment was marked as resolved.
This comment was marked as resolved.
|
@lorand-horvath, #190437 (comment) If ($IsLinux) {Remove-Item -Path "$HOME/.config/Code - Insiders/GPUCache"}remediates the problem. Because indeed this issue is dependent upon https://bugs.chromium.org/p/chromium/issues/detail?id=1442633, before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations. |
|
@deepak1556 Can you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks! |
deepak1556
added
bug
|
Thanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25. |
|
@deepak1556, could a patch at least be added to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple. |
|
We don't want to delete the GPUCache for all users and the affected scenario described in https://bugs.chromium.org/p/chromium/issues/detail?id=1442633#c29 is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility. |
Why? |
|
It will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact. |
|
Just happened again.
|
|
This is mentioned in the 1.82 release notes https://code.visualstudio.com/updates/v1_82#_update-highlights-for-chromium |
|
It appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided
|
They are probably using a different Electron version (that doesn't have this bug). |
|
This issue has been fixed upstream via this Chromium commit. It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue. |
|
The commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs? |
I haven't found any linked Electron issues yet.
Based on this document, since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order:
Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not. |
deepak1556
added
upstream-issue-fixed
|
@deepak1556 Thank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue. |
vscodenpa
added
the
unreleased
vscodenpa
added
insiders-released
deepak1556
added
the
author-verification-requested
|
This bug has been fixed in the latest release of VS Code Insiders! @RokeJulianLockhart, you can help us out by commenting If things still don't seem right, please ensure you're on version 54821ee of Insiders (today's or later - you can use Happy Coding! |
|
@VSCodeTriageBot, I'll verify when the next release reaches me on openSUSE. |
|
@RokeJulianLockhart by chance, were you able to verify the fix for the issue yet? |
This comment was marked as outdated.
This comment was marked as outdated.
|
Considering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. |
and others
Workaround
This is an issue in Chromium itself. For now there are the following two workarounds:
Broken shader compilation with mesa update #190437 (comment)
Broken shader compilation with mesa update #190437 (comment)
Bug
VS Code Version
Per:
code-insiders...the affected version is:
However, per:
...note that
--channel=latest/stable, that is:...works:
OS Version
uname -aSteps to Reproduce
code-insidersThe GUI is invisible:
...yet the menubar continues to operate correctly.
The text was updated successfully, but these errors were encountered: