Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Comments accessibility #192377

Closed
6 tasks done
alexr00 opened this issue Sep 7, 2023 · 3 comments
Closed
6 tasks done

Improve Comments accessibility #192377

alexr00 opened this issue Sep 7, 2023 · 3 comments
Assignees
@alexr00
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan
Milestone
September 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Sep 7, 2023 •
edited
Loading

  • Indicate when a document has commentable ranges
    • Aria status when a document is opened
  • Add keyboard shortcut for adding a comment
  • Provide commands to go to next and previous commentable range
  • Add an accessible help menu to the comment widget
    • Esc dismisses widget
    • Lists go to next/previous commentable range commands + keyboard shortcuts
    • Lists command and keyboard shortcut to add a comment
    • Lists keyboard shortcut to execute the comment primary action and what the primary action is
  • The Comments view should respect the enter/space = reveal+focus/reveal
  • Make the comment widget toolbar always visible when in screen reader mode
@alexr00 alexr00 added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 7, 2023
@alexr00 alexr00 added this to the September 2023 milestone Sep 7, 2023
@alexr00 alexr00 self-assigned this Sep 7, 2023
@joaomoreno
Copy link
Member

Related to microsoft/vscode-pull-request-github#1930

@alexr00 alexr00 mentioned this issue Sep 7, 2023
Closed
5 tasks
@kieferrm kieferrm mentioned this issue Sep 12, 2023
Closed
62 tasks
@alexr00 alexr00 mentioned this issue Sep 14, 2023
Merged
alexr00 added a commit that referenced this issue Sep 14, 2023
@alexr00
Always show comment widget toolbar in accessibility mode
d28edc6 
Part of #192377
@alexr00 alexr00 mentioned this issue Sep 14, 2023
Merged
alexr00 added a commit that referenced this issue Sep 14, 2023
@alexr00
Add keyboard shortcut for Add Comment
a96fd9a 
Part of #192377
alexr00 added a commit that referenced this issue Sep 14, 2023
@alexr00
Always show comment widget toolbar in accessibility mode (#193112)
e9c29d2 
Part of #192377
alexr00 added a commit that referenced this issue Sep 15, 2023
@alexr00
Add keyboard shortcut for Add Comment (#193118)
6d8c845 
Part of #192377
@alexr00 alexr00 mentioned this issue Sep 15, 2023
Merged
alexr00 added a commit that referenced this issue Sep 15, 2023
@alexr00
Aria status when editor has commenting ranges
c7fd3a4 
Part of #192377
alexr00 added a commit that referenced this issue Sep 15, 2023
@alexr00
Aria status when editor has commenting ranges (#193187)
ec45a64 
Part of #192377
@alexr00 alexr00 mentioned this issue Sep 15, 2023
Merged
alexr00 added a commit that referenced this issue Sep 15, 2023
@alexr00
Add next/previous commenting range commands+keybindings
f9f514a 
Part of #192377
alexr00 added a commit that referenced this issue Sep 15, 2023
@alexr00
Add next/previous commenting range commands+keybindings (#193209)
4e714a5 
Part of #192377
@alexr00 alexr00 mentioned this issue Sep 18, 2023
Merged
alexr00 added a commit that referenced this issue Sep 18, 2023
@alexr00
Follow enter vs. space focus vs. reveal convention
a17733b 
Part of #192377
alexr00 added a commit that referenced this issue Sep 18, 2023
@alexr00
Follow enter vs. space focus vs. reveal convention in Comments view (#…
d8e6919 
…193352)

Follow enter vs. space focus vs. reveal convention
Part of #192377
@alexr00 alexr00 mentioned this issue Sep 19, 2023
Merged
alexr00 added a commit that referenced this issue Sep 19, 2023
@alexr00
Add a context key for active editor commenting ranges
9aaf518 
Part of #192377
alexr00 added a commit that referenced this issue Sep 19, 2023
@alexr00
Add a context key for active editor commenting ranges (#193460)
fa45b00 
Part of #192377
@alexr00
Copy link
Member Author

alexr00 commented Sep 21, 2023

#193420 is the last part of this, and it's almost done!

@alexr00 alexr00 closed this as completed Sep 21, 2023
@alexr00 alexr00 mentioned this issue Sep 25, 2023
Closed
3 tasks
@MeekeawandNoppakun

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
September 2023
Development

No branches or pull requests
4 participants
@joaomoreno @alexr00 @vscodenpa @MeekeawandNoppakun