Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Editor Tab Height Density #193981

Closed
2 tasks done
benibenj opened this issue Sep 25, 2023 · 1 comment
Closed
2 tasks done

Test Editor Tab Height Density #193981

benibenj opened this issue Sep 25, 2023 · 1 comment

Comments

@benibenj
Copy link
Contributor

benibenj commented Sep 25, 2023

Refs: #42253

Complexity: 1

Create Issue


We added a new setting window.density.editorTabHeight: 'default' | 'compact'. This setting allows the user to reduce the height of editor tabs. It also affects the title bar when tabs are hidden (workbench.editor.showTabs: false).

imageimage

  1. Set window.density.editorTabHeight: 'compact', does the height of the title bar shrink? It should! Now toggle the workbench.editor.showTabs setting. Is it still small? It should be!
  2. Set workbench.editor.showTabs: true
  3. Set workbench.editor.wrapTabs: true and open many tabs until they wrap. The height of an individual tab should still be the same.
  4. Open a file that contains a line which has more characters then can fit in your window, causing a scrollbar to appear at the bottom of the editor. Check that the scrollbar is placed at the right height. (Placed on the bottom of the editor as in the image bellow)
image
@benibenj benibenj added this to the September 2023 milestone Sep 25, 2023
@ghost ghost assigned aiday-mar and minsa110 Sep 26, 2023
@aiday-mar aiday-mar removed their assignment Sep 26, 2023
@aiday-mar
Copy link
Contributor

This works well! Unrelated to this test plan item, I was testing this feature workbench.editor.wrapTabs and I noticed how the tab width all of a sudden changes on resize of the window. I am wondering if we want this behavior, because it looks a bit off to me. I think this is happening because we are wrapping the tabs (the other tab jumps to the bottom) but do we need the tab before to be so wide? I'll open an issue concerning this, perhaps it'll get upvotes.

Screen.Recording.2023-09-26.at.11.39.14.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants