Vertical alignment on tab icons seems unaligned when compact

[andreamah]

Testing #193981

1. Set window.density.editorTabHeight to compact
2. Notice that the icon almost looks too high compared to the text. For example, in my screenshot, the S in settings seems to not be aligned with the icon (off by a few pixels if you look closely).

[benibenj]

This has always been this way as it uses the line height to vertically align the text. It's just a bit more noticeable with the reduced tab height. @bpasero is there a reason why line-height is used instead of flexbox to vertically align the label and icon?

[bpasero]

@benibenj I actually do not remember, but feel free to explore alternatives and see if that improves it.

We also have #162995 opened which talks about a similar problem in the status bar I believe.

//cc @daviddossett @hbons

[daviddossett]

It may be because the line height of the text and the dimensions of the icon don't match. I run into this within Figma all the time :)

[bpasero]

Related :) https://tonsky.me/blog/centering/