Restoring comments again duplicates them

[joaomoreno]

Testing #193104

1. Follow the pre-requisites from Test continue on for PR comments #193104
2. In a file, sprinkle three separate comments.
3. Store changes in Cloud.
4. In another machine, same file, restore changes in Cloud. All three comments show up.
5. Update the first comment by adding a line.
6. Store changes in Cloud.
7. Back to the first machine, restore changes in Cloud.

🐛 Now there are 6 comments. All "new" 3 have been appended to the 3 existing comments.

[alexr00]

Good bug, thanks for finding!

[joyceerhl]

Hm, I can't get past step 4--the comments don't show up for me and I see this in the window logs

2023-11-30 15:03:19.635 [debug] Comments: URIs of continue on comments to add to storage .
2023-11-30 15:03:24.645 [debug] Comments: URIs of continue on comments to add to storage .
2023-11-30 15:03:29.733 [debug] Comments: URIs of continue on comments to add to storage .
2023-11-30 15:03:34.740 [debug] Comments: URIs of continue on comments to add to storage .

I then also see this in the GHPRI logs--before a resume, I am able to leave comments on edited ranges, and after a resume, the comment glyph widget is disabled for all edited ranges

2023-11-30 23:18:28.964 [debug] ReviewCommentController> Found matched file for commenting ranges.
2023-11-30 23:18:29.099 [debug] ReviewCommentController> Found 3 commenting ranges.
2023-11-30 23:18:29.131 [debug] ReviewCommentController> Providing 3 commenting ranges for intents.ts.
2023-11-30 23:18:50.315 [debug] GitPostCommitCommands> Looking for remote. Comparing 1 local repo remotes with 1 GitHub repositories.
2023-11-30 23:18:50.315 [debug] GitPostCommitCommands> Found a repo when getting post commit commands.
2023-11-30 23:18:50.315 [debug] GitPostCommitCommands> Looking for remote. Comparing 1 local repo remotes with 1 GitHub repositories.
2023-11-30 23:18:50.315 [debug] GitPostCommitCommands> Found a repo when getting post commit commands.
2023-11-30 23:18:50.451 [debug] ReviewCommentController> No commenting ranges: File has diffs, but they could not be mapped to current lines.
2023-11-30 23:18:50.451 [debug] ReviewCommentController> Providing 0 commenting ranges for intents.ts.

[alexr00]

@joyceerhl I can't reproduce this. Are you using 2 separate machines (or equivalent) + desktop VS Code?

[rzhao271]

LGTM.

Some notes:

• I had to add a line to the PR to get the changes to store the first time on the first machine (Linux), which corresponds to step 4 of Test continue on for PR comments #193104
• After restoring on the second machine (Windows), the PR comments didn't automatically show up. I had to refresh the PR for the comments to show up or update.

Adding verified because no duplicate comments showed up.