Aux window: drag and drop shows invalid drop feedback outside window and sometimes fails on macOS

[gjsjohnmurray]

Type: Bug

Testing #8171 on Windows 11, I was disconcerted to see the "no drop" pointer (red circle, red diagonal slash through it). But when I dropped, the aux window opened correctly.

VS Code version: Code - Insiders 1.85.0-insider (345c8d0, 2023-11-13T05:39:23.476Z)
OS version: Windows_NT x64 10.0.22621
Modes:

[gjsjohnmurray]

/assign @bpasero

[bpasero]

Unfortunately I do not see a way to address this without causing unwanted side effects on the target application that you are dropping, but if someone has suggestions, please speak up.

Essentially I want to indicate that dropping is possible but without the target application to accept the data (e.g. a terminal should not change the prompt with the data of the dragged tab).

Somewhat related: this also causes a noticeable delay on macOS until the window opens because on macOS there seems to be an animation first to move the dragged tab to where it was:

[bpasero]

Btw I cannot reproduce the "no drop" pointer when dropping over desktop:

[gjsjohnmurray]

Desktop still gives me the no-drop indicator using this morning's Insiders:

[bpasero]

Is that stable VS Code or insiders? I am not sure, but the logo looks blue.

[gjsjohnmurray]

It was Insiders.

[bpasero]

On macOS this is even worse because there is an ugly 500-1000ms animation for invalid drops that causes all sorts of issues:

• the entire operation feels sluggy and slow
• if you manage to move the mouse back over the main window shortly after releasing, we cancel the operation assuming you wanted to drop over the main window

[VSCodeTriageBot]

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

[bpasero]

For now this will not be changed until maybe we change to an entirely different solution that involves a more complicated approach without drag and drop. The macOS delay issue will be addressed.