Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ergonomics between Quick Search and the Search view #201735

Closed
andreamah opened this issue Jan 3, 2024 · 3 comments
Closed

Improve the ergonomics between Quick Search and the Search view #201735

andreamah opened this issue Jan 3, 2024 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan search Search widget and operation issues

Comments

@andreamah
Copy link
Contributor

andreamah commented Jan 3, 2024

With the introduction of quick search, we have the ability to switch between quick search and the search viewlet, but it's not too convenient to use because you need to scroll to the end of the list.

image

Overall, it would be nice to have a better experience switching between the two views.

@andreamah andreamah added feature-request Request for new features or functionality search Search widget and operation issues labels Jan 3, 2024
@andreamah andreamah added this to the December / January 2024 milestone Jan 3, 2024
@andreamah andreamah self-assigned this Jan 3, 2024
@andreamah
Copy link
Contributor Author

I've added an arrow that takes you to the search view with that match highlighted:
image

We would probably be better off with a different codicon, though. Maybe the search codicon or something new?

@andreamah
Copy link
Contributor Author

image

From demoing, I got the feedback that the right arrow wasn't the best icon to use. I opted to use this icon throughout. However, I don't think it's necessarily the most descriptive icon for this case.

@hbons do you think that we could create a new icon that is like what is below, but with an arrow instead of a squiggle?
image

I think that something like that would be good in this case. By the way, if you want to try out this feature to see whether the icon would actually fit, you can see how to do so here: https://code.visualstudio.com/updates/v1_82#_quick-access-text-search

@andreamah
Copy link
Contributor Author

Closing, just need to address #202906

@andreamah andreamah added the on-release-notes Issue/pull request mentioned in release notes label Jan 26, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants