Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the multi-file diff editor for rendering refactor previews #204370

Closed
1 of 3 tasks
hediet opened this issue Feb 5, 2024 · 4 comments
Closed
1 of 3 tasks

Adopt the multi-file diff editor for rendering refactor previews #204370

hediet opened this issue Feb 5, 2024 · 4 comments
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Feb 5, 2024

This feature request is about using the multi-diff editor in order to render the preview from the refactor preview view. Currently each change is shown in its own diff editor. We have decided to adopt the following approach to implement this:

  • On click of the refactor preview, open a multi-diff editor showing all the changes
  • Place the refactor preview view directly into the multi-diff editor. Currently it is in an output view, on the same level as the terminal.
  • Explore combining the tree of changes with the multi-diff editor
@hediet hediet added feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming editor-code-actions Editor inplace actions (Ctrl + .) labels Feb 5, 2024
@hediet hediet modified the milestones: Backlog, February 2024 Feb 5, 2024
@tjx666
Copy link
Contributor

tjx666 commented Feb 6, 2024

cool

@aiday-mar
Copy link
Contributor

One idea that was proposed by @lszomoru is to show the refactor preview in the side panel instead of within the editor (just like the results of find references). This would free some vertical space for the multi diff editor, and would allow us to reuse an existing component.

@jrieken
Copy link
Member

jrieken commented Feb 14, 2024

You can also do that. Just dnd the panel while it shows*

Screenshot 2024-02-14 at 17 27 24

* There is a glitch that the first time the view reset but the position is persisted and then one in the side bar.

@aiday-mar
Copy link
Contributor

Ah yes that's right

@aiday-mar aiday-mar modified the milestones: February 2024, March 2024 Feb 20, 2024
@aiday-mar aiday-mar added verified Verification succeeded and removed verified Verification succeeded labels Mar 26, 2024
@rzhao271 rzhao271 added verification-needed Verification of issue is requested verified Verification succeeded and removed verified Verification succeeded labels Mar 26, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 26, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants