Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to open changelog when an extension is updated #21583

Closed
ramya-rao-a opened this issue Mar 1, 2017 · 18 comments
Closed

Offer to open changelog when an extension is updated #21583

ramya-rao-a opened this issue Mar 1, 2017 · 18 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 1, 2017

With every update to VS Code, users now get a prompt to read the release notes.
It would be nice to have the same feature for extensions. Prompt to read the Changelog (if exists) on every update to the extension

Edit:
Prompt might be a bit much, too many notifications. Instead a "What's new" button or a similar option when clicking on the gear icon would be better

@ramya-rao-a ramya-rao-a added the extensions Issues concerning extensions label Mar 1, 2017
@sandy081 sandy081 added this to the Backlog milestone Mar 1, 2017
@ramya-rao-a
Copy link
Contributor Author

Slack has this "gift" icon. On hover it says "What's new". Clicking opens a side pane with the new features.

In the extensions pane, we now have the "Update to .." button when there is an update available.
We can use the same space for a "What's new" button when there is no update and changelog exists for the extension. Clicking on which should open the Changelog tab.

@stevencl Thoughts?
cc @Microsoft/vscode

@chrmarti
Copy link
Contributor

I like the idea of increasing the visibility of extensions' progress. One issue might be that all extensions end up having that changelog button because (almost) all have a prior version. That would decrease its value as a 'highlight'.

@bpasero
Copy link
Member

bpasero commented Mar 14, 2017

-1, I have set my extensions to auto update and I would never want to see any release editor opening. I am quite happy with this kind of silent updates.

@joaomoreno
Copy link
Member

As long as it doesn't come as notification, I'm fine with that... The more I call showInformationMessage, the less chances I have to get into Heaven.

@stevencl
Copy link
Member

A 'What's new' button after the user has updated an extension would be a decent solution. I definitely don't think we should be notifying the user.

Once the user closes VS Code and restarts, we would remove the What's New button. We could consider then exposing a 'View changelog' action in the gear/settings menu to provide access to the changelog if it exists. That way we could avoid the problem that @chrmarti points out.

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Mar 14, 2017

Agreed on the "no more notifications please" thought.
Updated the issue description accordingly.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Apr 7, 2017
@joaomoreno joaomoreno removed their assignment Jun 19, 2017
@eamodio
Copy link
Contributor

eamodio commented Dec 28, 2017

I would LOVE to see a feature like this. I've posted some of my comments here: gitkraken/vscode-gitlens#222 (comment)

Personally I think it is important for an extension to be able to provide details around an update (changelog, release notes, etc). But the current notification mechanism is far from ideal. IMO, it should be something discoverable but passive.

I kind of like the idea of a badge on the extensions button (which would go away if you open the extension pane) if there have been any updates. And then individual badge each extension that has been updated -- that would bring you to a changelog or something like that. Although the downside, is lots of badges that might not get looked at and therefore not cleared, which would just become visual noise.

Another option, would still have the same badge on the extensions button, but the extensions pane would also have that badge as a button somewhere, and clicking that would open up a single screen, with a list of any updates. This could either be automatic (i.e. vscode will track the updates), manual (a new api for an extension to add an entry), or a combination of both. I think a combination would be ideal. Where vscode would track the simple, Extension Foo was upgraded from 1.0 -> 2.0 (maybe with a changelog link if there is one), and an extension could add additional details (bounded) through a new api -- maybe something like showInformationMessage (addUpdateMessage)?

Thoughts?

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Jan 22, 2018

@bpasero This is something we should include in the notification improvement story #22388?

@bpasero
Copy link
Member

bpasero commented Jan 22, 2018

@ramya-rao-a yeah we briefly touched on this. what if the update notification for an extension would show within the extensions viewlet instead of the global notification area?

@ramya-rao-a
Copy link
Contributor Author

That would work, are we planning to cover that as part of #22388?

@bpasero
Copy link
Member

bpasero commented Jan 22, 2018

@ramya-rao-a no, we would probably need a new story for that one. What we have planned is to show the source of a notification more prominently so distinguish core notifications from extension notifications.

@bpasero bpasero added the workbench-notifications Notification widget issues label Jan 22, 2018
@bpasero bpasero changed the title Feature Request: Offer to open changelog when an extension is updated Offer to open changelog when an extension is updated Feb 20, 2018
@bpasero bpasero removed the workbench-notifications Notification widget issues label Feb 20, 2018
@StephenWeatherford
Copy link

+1 on VS Code's adding the ability for an extension to display release notes in a centralized, not-in-your-face way that users could enable or disable. I've seen several extensions open up release notes automatically after they're updated (e.g. C/C++ extensionm, see below). We'd also like the ability to let users know when new features are available, but if we do it ourselves it will add more noise.

@chrisdias and @fiveisprime did a survey to see whether customers would like this feature - 90% of users indicated they liked the feature, but half felt it was annoying as currently implemented:

image

Further from Chris

I think we want to do something in the core product to make this experience better, so I wouldn’t put this into the extension(s) yet. I can imagine a new type of notification (hidden by default maybe?), a better badge system, a way to go to the extension changelog.md, etc. Then, the azure extensions can plug into that model.

FYI, here' an example of a current extension full-screen notification (not us :-):
image

@StephenWeatherford
Copy link

(Not sure how this issue relates to #44020.)

@moshfeu
Copy link
Contributor

moshfeu commented May 24, 2020

Is this implemented yet? Because I think I saw a notification in vscode about an extension been updated and button which opens the extension's changelog

@sandy081 sandy081 modified the milestones: Backlog, On Deck May 25, 2020
@sandy081
Copy link
Member

Not yet, but I will be starting to explore based on the feedback that is provided here. So ideas are very much welcome.

@sandy081 sandy081 modified the milestones: On Deck, Backlog Nov 9, 2020
@sandy081
Copy link
Member

sandy081 commented Nov 9, 2020

There's discussion happening here - #102139

@anburocky3
Copy link

Out of curiosity, I see some extensions found a way to accomplish this way. But is there any vscode documentation to implement it ourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

11 participants