Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Add / or \ to the end of directories as appropriate #234621

Closed
Tyriar opened this issue Nov 25, 2024 · 1 comment
Closed

Terminal suggest: Add / or \ to the end of directories as appropriate #234621

Tyriar opened this issue Nov 25, 2024 · 1 comment
Assignees
@meganrogge
Labels
feature-request Request for new features or functionality terminal-suggest verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 25, 2024

I fine tuned the pwsh completions to handle this really nicely. The rules are:

  • Add a slash to every folder that's provided
  • Don't add slash to the end of simple . and .. completions. This is done since they're special and are often used on their own, so users are required to add the slash to continue on. This is somewhat of a remnant of runOnEnter being the default but I think it makes sense to keep it this way.
  • Add a slash to the end of compound .. completions (eg. ../ should have the completion ../../)

This allows navigating directories intuitively with arrows + tab

Image
Image
@Tyriar Tyriar mentioned this issue Nov 26, 2024
Merged
@meganrogge meganrogge added feature-request Request for new features or functionality terminal-suggest labels Nov 26, 2024
@meganrogge meganrogge added this to the November 2024 milestone Nov 26, 2024
meganrogge added a commit that referenced this issue Nov 26, 2024
@meganrogge
fix #234621
555ab48
@meganrogge meganrogge mentioned this issue Nov 26, 2024
Closed
@meganrogge meganrogge added the verification-needed Verification of issue is requested label Dec 2, 2024
@alexr00 alexr00 added the verified Verification succeeded label Dec 3, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 3, 2024

Verified, but opened #235154.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality terminal-suggest verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

support ../../ in terminal completions microsoft/vscode
3 participants
@Tyriar @meganrogge @alexr00