Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-line jsdoc annotations #27777

Closed
ribrdb opened this issue May 31, 2017 · 4 comments
Closed

Support multi-line jsdoc annotations #27777

ribrdb opened this issue May 31, 2017 · 4 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar javascript JavaScript support issues languages-basic Basic language support issues verified Verification succeeded
Milestone
April 2019

Comments

@ribrdb
Copy link

ribrdb commented May 31, 2017

  • VSCode Version: 1.12.2
  • OS Version: macOS 10.12.5

Steps to Reproduce:

  1. Open a javascript file with multi-line type annotations. For example:
    https://github.com/google/closure-library/blob/master/closure/goog/dom/animationframe/animationframe.js#L61

Expected result:
VSCode highlights the jsdoc.

Actual Result:
VSCode highlights the jsdoc in red like there's an error.
@mjbvz mjbvz self-assigned this May 31, 2017
@mjbvz mjbvz mentioned this issue May 31, 2017
Closed
@mjbvz mjbvz added javascript JavaScript support issues languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 31, 2017
@mjbvz mjbvz mentioned this issue May 31, 2017
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented May 31, 2017 •
edited
Loading

Opened microsoft/TypeScript-TmLanguage#467 for the syntax highlighting issue and microsoft/TypeScript#16179 for actually understanding a multiline jsdoc type

@mjbvz mjbvz closed this as completed May 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 11, 2019

Reopening since it looks like this will not be fixed upstream, see microsoft/TypeScript-TmLanguage#740

@mjbvz mjbvz reopened this Apr 11, 2019
@microsoft microsoft unlocked this conversation Apr 11, 2019
@mjbvz mjbvz added this to the April 2019 milestone Apr 11, 2019
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar labels Apr 11, 2019
mjbvz added a commit that referenced this issue Apr 11, 2019
@mjbvz
Fix multiline jsdoc type highlightingFixes #27777
0ae3ecb
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 12, 2019

Fixed by 0ae3ecb

@mjbvz mjbvz closed this as completed Apr 12, 2019
@mjbvz mjbvz removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 12, 2019
@alexr00 alexr00 added the verified Verification succeeded label May 8, 2019
@chrisdothtml
Copy link

chrisdothtml commented May 15, 2019 •
edited
Loading

@mjbvz has this fix been released yet to the official release stream? Seems to be still not working in v1.33.1

EDIT: Looks like v1.33.1 was released April 11th, so guessing this fix will be included in the next official release

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar javascript JavaScript support issues languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Milestone
April 2019
Development

No branches or pull requests
4 participants
@ribrdb @chrisdothtml @mjbvz @alexr00