Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: set aria-setsize and aria-posinset #27900

Closed
bpasero opened this issue Jun 2, 2017 · 7 comments · Fixed by #29118 or #29019
Closed

Tree: set aria-setsize and aria-posinset #27900

bpasero opened this issue Jun 2, 2017 · 7 comments · Fixed by #29118 or #29019
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues release-notes Release notes issues tree-widget Tree widget issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 2, 2017

The tree/list is virtualized and as such a screen reader cannot make a correct statement on the number of entries. We should leverage aria-setsize and aria-posinset for that purpose within the tree and list widgets. The widgets know the number of elements to render and the currently selected items position in the set.

/cc @joaomoreno @isidorn

@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2017

Makes sense, I can look into it in june

@isidorn
Copy link
Contributor

isidorn commented Jun 19, 2017

Accidently closed this by PR which only address the list widget, still gotta do it for the tree

@isidorn
Copy link
Contributor

isidorn commented Jun 20, 2017

After looking into this with @joaomoreno we have fixed this issue for the list, however for the tree the situation is a bit more complex:

  • It is not exactly specified what the aria-posinset and aria-setsize should be with respect to the tree structure. Should they be absolute or only relative to the siblings.
  • In both of the cases we have an issue that the tree smartly chooses the minimal set of elements that need to be re-rendered, so if an element A gets removed and element B is above it, B will not get re-rendered and will still have the wrong aria-setsize attribute.

Due to that we would need a bigger refactoring in order to fix this for the tree. So renaming this issue and pushing it to backlog for now.

@isidorn isidorn changed the title Tree/List: set aria-setsize and aria-posinset Tree: set aria-setsize and aria-posinset Jun 20, 2017
@isidorn isidorn modified the milestones: Backlog, June 2017 Jun 20, 2017
@alexdima
Copy link
Member

The originating issue -- microsoft/monaco-editor#444 -- came in w.r.t. the Command Palette that displays a list. @bpasero perhaps the root issue is that the implementation of the Command Palette uses a tree to display a list and that makes it difficult to express the list to Screen Readers ?

@isidorn
Copy link
Contributor

isidorn commented Jun 20, 2017

+1 for making the command palette use the list. I could also look into this when I get cycles if @bpasero does not mind.

@bpasero
Copy link
Member Author

bpasero commented Jun 20, 2017

@isidorn yeah +1 for using list for quick open, that would be very nice 👍 . I hope there are no things in tree that quick open depends on.

@isidorn
Copy link
Contributor

isidorn commented Jun 20, 2017

I have created this issue to track it #29096

@isidorn isidorn added the release-notes Release notes issues label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues release-notes Release notes issues tree-widget Tree widget issues
Projects
None yet
3 participants