-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up multiroot exclude glob handling #29505
Comments
@roblourens fyi I introduced This helper takes care of:
Unfortunately I think it currently cannot easily be used together for |
I spent some time trying to share ResourceGlobMatcher with search, but decided it doesn't make sense, since search is dealing with search queries and search paths, which may or may not be root folders, and if you factor that out, then you just aren't sharing that much. Also, I don't think the pattern caching in ResourceGlobMatcher is that useful because glob.ts already caches all parsed patterns. So I have a large change in progress that centralizes the "search query interpretation" logic for fileSearch.ts and the stuff in the renderer process, and fixes #31819 in a nice clean way, but it's a WIP. And in parallel I'm still thinking about changing the search query format anyway, so... this goes to September. |
Lots has changed here |
From #29164
We need to have a centralized place where exclude globs are resolved in a multiroot-aware fashion. Right now this is done differently in different places because the scenarios have different needs, are running in different processes, etc and I couldn't decide how to organize it in June.
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/search/node/ripgrepTextSearch.ts#L383
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/search/node/fileSearch.ts#L91
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/history/browser/history.ts#L120
The text was updated successfully, but these errors were encountered: