Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Search viewlet changes #31480

Closed
2 tasks done
roblourens opened this issue Jul 26, 2017 · 2 comments
Closed
2 tasks done

Test: Search viewlet changes #31480

roblourens opened this issue Jul 26, 2017 · 2 comments
Labels
search Search widget and operation issues testplan-item
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Jul 26, 2017

This covers #27226 and #29977

Complexity: 4

  • Try search viewlet in multiroot and non-multiroot mode. The multiroot UI should be usable and make sense. The non-multiroot UI should look the same.
  • Try the "Find in Folder" context menu item. In multiroot mode it should use ./ syntax, with the root's basename, in "files to include" unless there is another root folder with the same basename. In that case it should use an absolute path. In single root mode, it should always use ./
  • Try combinations of ./ and glob patterns in "files to include"
  • Should get a reasonable error message for ./ and absolute paths that don't exist
  • Try different things in include/exclude. Now that the glob buttons are missing, foo should match **/foo,foo/** (ie, a folder at the root named foo, or all files named foo)
  • Don't forget to try things with "search.useRipgrep": false.
  • Open files should now respect the include/exclude settings
@roblourens roblourens added search Search widget and operation issues testplan-item labels Jul 26, 2017
@roblourens roblourens added this to the July 2017 milestone Jul 26, 2017
@roblourens
Copy link
Member Author

One of you, please try Windows

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2017

I'll do Windows

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues testplan-item
Projects
None yet
Development

No branches or pull requests

3 participants