Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we present multiple search results on the same line more effectively? #31817

Closed
Tyriar opened this issue Aug 1, 2017 · 4 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues ux User experience issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2017

  • VSCode Version: Code - Insiders 1.15.0-insider (f39385b, 2017-08-01T05:16:44.254Z)
  • OS Version: Windows_NT x64 10.0.14393
  • Extensions:
Extension Author (truncated) Version
git-project-manager fel 1.3.2
seti-icons qin 0.1.3

(1 theme extensions excluded)


Testing #31480

(I may have created an issue similar to this before)

It's always annoyed me the same line shows up multiple times in the search results, even when the line is really small and would fit in the viewlet just fine. Consider this example where the first line is complete:

image

This would be better ideal in this case (I modified the DOM):

image

I understand the argument against this, where really long lines cannot show multiple results like this. Maybe we can size the search results to suit the width of the search viewlet, re-laying out the results when the viewlet is resized?


Here's the extreme case illustrating the issue:

image

@Tyriar Tyriar added search Search widget and operation issues ux User experience issues labels Aug 1, 2017
@vscodebot vscodebot bot added the insiders label Aug 1, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Aug 1, 2017

It's worth pointing out that the proposed solution would make it more in line with how search results are presented in the editor as well:

image

@roblourens
Copy link
Member

That would be cool but the viewlet is very narrow and rendering the tree takes a long time.

@roblourens roblourens added the feature-request Request for new features or functionality label Aug 1, 2017
@chrmarti chrmarti removed the insiders label Sep 27, 2017
@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Nov 23, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 23, 2017

This feature request will not be considered in the next 6-12 months roadmap and has been closed to keep the number of issues we have to maintain manageable. See also our issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Nov 23, 2017
@roblourens
Copy link
Member

I think most real world searches wouldn't benefit much. There are other issues for search viewlet UX in general though.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants