Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping a debug session should close the debug console #3829

Closed
egamma opened this issue Mar 8, 2016 · 7 comments
Closed

Stopping a debug session should close the debug console #3829

egamma opened this issue Mar 8, 2016 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality polish Cleanup and polish issue

Comments

@egamma
Copy link
Member

egamma commented Mar 8, 2016

  • start a debug session
  • the debug tool bar appears
  • the debug console appears
  • debug

When pressing stop in the debug tool bar

  • the debug tool bar disappears

At this point the debug console should also be closed.

@egamma egamma added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue labels Mar 8, 2016
@egamma egamma added this to the March 2016 milestone Mar 8, 2016
@egamma egamma mentioned this issue Mar 8, 2016
82 tasks
@isidorn isidorn closed this as completed in a4f8a16 Mar 8, 2016
@isidorn isidorn assigned egamma and unassigned isidorn Mar 8, 2016
@isidorn
Copy link
Contributor

isidorn commented Mar 8, 2016

After discussing with @weinand I am hiding the console on any end of a debug session. For instance, also if the user terminates the debugee

@egamma
Copy link
Member Author

egamma commented Mar 19, 2016

@isidorn I think there is nothing to verify here since we rolled back this change, correct?

@isidorn
Copy link
Contributor

isidorn commented Mar 19, 2016

@egamma exaclty, we rolled back the change

@pflannery
Copy link

At this point the debug console should also be closed.

If I understand vscode is now going hide the debug console after pressing stop.
My problem with this change is its essential to see the output history trail of a debug session even if pressing the stop button half way through a session.

Here is an example of stopping debugging with v0.10.11 and what I see after I press stop.

image

If this is going to forced on us can we make this a configurable debug option?

@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2016

Right now vscode will never automatically hide the debug console.
We are looking into adding an configuration for debug console behavior which is captured in another issue

@pflannery
Copy link

@isidorn ok, I'm probably getting the wrong idea here. I'm look forward to the next release! thanks

@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2016

@pflannery this was just a tryout idea which we reverted in the end.

@egamma egamma removed this from the March 2016 milestone Mar 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants