Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test localized product #4018

Closed
3 tasks done
dbaeumer opened this issue Mar 11, 2016 · 10 comments
Closed
3 tasks done

Test localized product #4018

dbaeumer opened this issue Mar 11, 2016 · 10 comments

Comments

@dbaeumer
Copy link
Member

Assignees:

Items:
Please note that minor parts of the product are still not translated. We have in total 136 untranslated strings. If a strings shows up in the user interface untranslated and you want to check if the strings is correctly externalized start in locale=pseudo and check if the string is enclosed in [ ] and has doubled vowels.

  • Start VSCode from the command line and pass the --locale argument. Test the following values and ensure that the UI is at least partly localized: de, es, fr, it, ja, ko, ru, zh-cn, zh-tw.
  • Test that language reduction works. Start code with --locale=de-DE and ensure that you get a German user interface
  • Test that VSCode picks up your OS setting. So switch the OS to one of the above locales and start VSCOde WITHOUT the locale parameter. Ensure that the user interface is rendered in the correct language.
@alexdima
Copy link
Member

I did not test detecting the OS setting. Erich mentioned that it worked for him in the stand-up, as he got VS Code in German.

@waderyan
Copy link

@dbaeumer am I testing this correctly?

I'm on OSX. I have the latest alpha version - Version 0.10.12-alpha

I have tried each of these commands, but have not seen any translations.

code-alpha --locale=de .
code-alpha --locale=psuedo .
code-alpha --locale=de-DE .
code-alpha --locale=es .
code-alpha --locale=zh-cn . 

Because psuedo doesn't work I can't determine what should be externalized. Here are the places I am looking.

Search bar.

image

Git.

image

File Menus.

@dbaeumer
Copy link
Member Author

That should work and @weinand tested this. Not sure why this doesn't work for you. Can you check if you see files like this in your installation:

capture

Using the corresponding paths under Mac

@waderyan
Copy link

Looks like they are all there. Am I using the command line correctly? I'll check on some of the other Mac machines here.

image

@weinand
Copy link
Contributor

weinand commented Mar 14, 2016

@waderyan make sure that VS Code is not running before you launch it from the command line with the local flag. Otherwise the locale flag is ignored.
And make sure to spell "pseudo" correctly ;-)

@waderyan
Copy link

Ha. That was it (both the running app and the spelling problem). Works on command line now :)

@waderyan
Copy link

Found an issue with OS detection. logged here

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2016

@waderyan are you done testing this item? If yes you forgot to check off the checkbox?

@waderyan
Copy link

@isidorn I have finished testing but there is still an outstanding issue #4120. From your question i'm assuming I should still mark testing as complete even with an outstanding issue.

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2016

@waderyan yes, once we are done testing we check off the test item. The issues track the state of that, not this test plan item

@isidorn isidorn closed this as completed Mar 15, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants