Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch up with TS 1.8.9 and honour file size event #4185

Closed
jrieken opened this issue Mar 14, 2016 · 5 comments · Fixed by #113377
Closed

catch up with TS 1.8.9 and honour file size event #4185

jrieken opened this issue Mar 14, 2016 · 5 comments · Fixed by #113377
Assignees
@jrieken
Labels
typescript Typescript support issues verified Verification succeeded
Milestone
March 2016

Comments

@jrieken
Copy link
Member

jrieken commented Mar 14, 2016

No description provided.

@jrieken jrieken self-assigned this Mar 14, 2016
@jrieken jrieken added this to the March 2016 milestone Mar 14, 2016
@jrieken jrieken mentioned this issue Mar 15, 2016
Closed
@chrisdias
Copy link
Member

please see my comments in #4254, i am not prompted on OSX either.

@chrisdias
Copy link
Member

related to #4007

@jrieken
Copy link
Member Author

jrieken commented Mar 16, 2016

@chrisdias You see a crash because there are too many files. Unless we have a proper tsserver you must be careful to find the right amount of files - more than 500 less than it takes to crash the server

@chrisdias
Copy link
Member

@jrieken when should i expect to get prompted to configure excludes then?

@jrieken
Copy link
Member Author

jrieken commented Mar 17, 2016

when you have more than 500 files but (less than it takes to crash the server OR a recent server build which handles this better)

@jrieken jrieken assigned dbaeumer and unassigned jrieken Mar 17, 2016
@dbaeumer dbaeumer added the typescript Typescript support issues label Mar 21, 2016
@dbaeumer dbaeumer assigned jrieken and unassigned dbaeumer Mar 21, 2016
@jrieken jrieken added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
alexr00 added a commit that referenced this issue Dec 24, 2020
@alexr00
Start candidate finding later (#113377)
0b1892f 
And filter out the renderer.
Fixes #4185, #4110
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

Successfully merging a pull request may close this issue.

Start candidate finding later microsoft/vscode
3 participants
@chrisdias @jrieken @dbaeumer