Add support for "logPoints"

[weinand]

Umbrella item for LogPoints:

• show breakpoint icon in Breakpoints view (finished in February Show unverified function breakpoints in debug viewlet #3388)
• DAP: Add support for log-points Typing in the editor is very laggy on Linux #162
• treat source breakpoints with logMessage as logPoints in the UI
  • show them with diamond shaped icon
• new "Add Logpoint" and "Edit Logpoint..." actions in gutter
• new peek UI for editing logPoint message
  • Support language specific intellisense in logMessage peek UI Support language specific intellisense in breakpoints conditions and logMessage peek UI #45127
• surface logMessage in extension API (see surface logMessage in extension API #45643)
• implement logPoint semantics in node-debug
• implement logPoint semantics in node-debug2 (see Add support for LogPoints in Node vscode-node-debug2#163)

[isidorn]

@chryw fyi this milestone we will also be using the nice log point icon you provided us. Once you go over our icons to standardise them you could also make sure the log point is consistent with other icons as well.

[weinand]

@isidorn in the DAP the "logMessage" exists only on the SourceBreakpoint but for VS Code I suggest that "logMessage" lives on some common base class for SourceBreakpoint and FunctionBreakpoint. Most likely I'll add a "logMessage" on the FunctionBreakpoint soon.

It would be great if all the common attributes "enabled", "condition", "hitCondition", "logMessage", "id", would live in a baseclass...

And for the logMessage UI I suggest that we just add a third "page" to the Peek UI. And the "Add Logpoint" and "Edit Logpoint" actions would just open this third page automatically.

[isidorn]

@weinand agree, I will try to structure it like that this afternoon.

[isidorn]

I have created test plan item #45962
Feel free to modify it

[weinand]

@isidorn you've checked off new "Add Logpoint" and "Edit Logpoint..." actions in gutter.
I'm not seeing those actions? Am I missing something?

[isidorn]

@weinand you can see them if you run vscode out of source. They will be avilable in tomorrows insiders.
As for the Edit Logpoint - will not introduce that action since there is an edit breakpoint actions which is smart enough imho.

[weinand]

I am running out of latest source but I was only looking for the "Edit Log Point" actions...

[isidorn]

If demand is high I can rename the "Edit Breakpoint" action to "Edit Log Point" if the user clicks on a log point.

[auchenberg]

@isidorn @roblourens @weinand Do we want to mention LogPoints in this iterations release notes? I'm not convinced our implementation for Node is ready for prime time, per learnings from yesterday: microsoft/vscode-node-debug#174 (comment)

One option for us could be to prefix it with "Preview"

[nonameolsson]

Does this only apply for Node? Not PHP?

[weinand]

@nonameolsson from the 1.22 release notes:

Debug extensions have to actively opt into this feature.
You might want to file a feature request against PHP.