Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a lightweight shell selector without changing default (ie. terminal profiles) #45444

Closed
tigerhawkvok opened this issue Mar 9, 2018 · 17 comments · Fixed by #118790
Closed
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label
Milestone

Comments

@tigerhawkvok
Copy link

  • VSCode Version: 1.21.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a Powershell terminal
  2. Split the terminal window
  3. Try to open a WSL Ubuntu terminal

It'd be great to split the terminal types for different cases!

I imagine that if you pressed and held the "+" you could select other terminals on your system, or similar UI for this.

@vscodebot vscodebot bot added the new release label Mar 9, 2018
@stellirin
Copy link

Yes, yes, yes! I wanted this for a long time, I finally came to report this and saw this report.

An example workflow:

  • docker-compose work is done in PowerShell
  • git work is done in Bash

This is mostly since it's pretty painful right now to get the WSL docker engine to talk nicely to Docker on Windows. I read it'll be easier in Windows 1803.

However we also have to develop dual scripts for Windows/Unix environments. Opening them side-by-side in the editor, AND the relevant terminals side-by-side beneath them would be really cool.

@kieferrm kieferrm added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Mar 11, 2018
@fabiospampinato
Copy link
Contributor

I imagine that if you pressed and held the "+" you could select other terminals on your system, or similar UI for this.

"press and hold" isn't used anywhere else in the app, so maybe this should work just on click, or maybe on right click.

In the meantime you can kind of do this already with my Terminals Manager extension, support for split terminals is in the making.

@Tyriar
Copy link
Member

Tyriar commented Mar 12, 2018

Normally I close these issues off and point people to https://marketplace.visualstudio.com/items?itemName=Tyriar.shell-launcher but I do hear this quite a bit, at least for Windows users, to have a dropdown appear when you click the + button. I'll keep this open to gather more feedback, I'm a little unsure how the flow would work right now what would happen when you hit ctrl+` or ctrl+shift+`, maybe launching a default terminal unless you hit the plus button with the mouse?

@Tyriar Tyriar added the ux User experience issues label Mar 12, 2018
@tigerhawkvok
Copy link
Author

tigerhawkvok commented Mar 13, 2018 via email

@mittalyashu
Copy link

I want to use different terminal, based upon the work I am doing and there should be an option that which type of terminal you want to launch.

Rails

image

Git

image

Instead of providing single option for terminal ``"terminal.integrated.shell.windows": "C:\Program Files\Git\bin\bash.exe".

There should be an option for defining multiple terminal for different language:

{
"terminal": {
"git": "C:\\Program Files\\Git\\bin\\bash.exe",
"ruby": "C:\\Program Files\\ruby.exe",
"python": ...
}
}

@Tyriar Tyriar changed the title Allow more than one terminal shell configuration Provide a lightweight shell selector without changing default (ie. terminal profiles) Oct 8, 2019
@Tyriar Tyriar removed the ux User experience issues label Oct 8, 2019
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Oct 8, 2019
@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2019

The implementation of this will probably be relatively simple, I imagine another section in the dropdown that includes the profiles in between the current terminal processes and the select default shell entry:

image

Some thinking needs to be put into how profiles will be structured in settings, open to proposals (and PRs once we decide on a schema).

@MmAtBosch
Copy link

When will this small but awesome function get finally reality??
Please 🙏🏻

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2021

@ManuelMinkAtBOSCH it's a stretch goal for the next release 🚀

@LucaGabi
Copy link

LucaGabi commented Mar 9, 2021

Would you upvote this thicket as it's more clearly described ?

#118028

@IAmHopp
Copy link

IAmHopp commented Apr 1, 2021

Guys, I see we can pass args to the terminal profile we're adding. Would it be possible to eventually pass environment variables, such that I can open a terminal pre-prepared for a specific task or set of tasks I want to do?

(I tried achieving this using Tasks as well, but I need to keep a terminal open at the end, so I couldn't find a clean solution there either)

@Tyriar
Copy link
Member

Tyriar commented Apr 1, 2021

@IAmHopp 👍 created #120366

@pszlazak
Copy link

pszlazak commented Apr 7, 2021

Guys, I see we can pass args to the terminal profile we're adding. Would it be possible to eventually pass environment variables, such that I can open a terminal pre-prepared for a specific task or set of tasks I want to do?

@IAmHopp - please check my comment in #120366.

@IAmHopp
Copy link

IAmHopp commented Apr 7, 2021

@pszlazak I think in the end we're suggesting the same thing.

@gotofritz
Copy link

gotofritz commented Apr 18, 2021

This was a terrible idea - are you aware that some people use the terminal in column mode? Now that menu that I (and I suspect most users) will NEVER need takes up half the space .... and you don't even allow us to hide the pulldown and reclaim the space

Created a ticket for improving this
#121572

@Tyriar
Copy link
Member

Tyriar commented Apr 18, 2021

@gotofritz commented on that issue. To clarify, profiles (this issue) are the detected and configurable shells in the terminal dropdown (or the v button in the tabs view).

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal General terminal issues that don't fall under another label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

14 participants