Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input box: do not close when pressing ENTER on invalid input #45583

Closed
DanTup opened this issue Mar 12, 2018 · 3 comments
Closed

Input box: do not close when pressing ENTER on invalid input #45583

DanTup opened this issue Mar 12, 2018 · 3 comments
Assignees
@chrmarti
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2018

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 12, 2018

It's confusing that when showInputBox is given an invalid value that pressing <enter> just closes the box and returns undefined. I've had users that have said things are broken because they typed a value and pressed enter - their value was invalid and they didn't notice the prompt (because they typed and pressed enter quickly).

Either we should be able to tell when the user pressed <enter> on an invalid value, or they shouldn't be able to - the box should just stay visible with the validation error until the fix it or use <esc> to cancel.
@DanTup DanTup mentioned this issue Mar 12, 2018
Closed
@jrieken jrieken added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Mar 12, 2018
@bpasero
Copy link
Member

bpasero commented Mar 12, 2018

/cc @chrmarti

@bpasero bpasero changed the title Unable to tell the difference between a user pressing <escape> or pressing <enter> with an invalid value in showInputBox Input box: do not close when pressing ENTER on invalid input Mar 12, 2018
@chrmarti chrmarti mentioned this issue Mar 13, 2018
Closed
@DanTup DanTup mentioned this issue Mar 26, 2018
Closed
@bpasero bpasero removed their assignment Apr 26, 2018
@chrmarti chrmarti assigned chrmarti and unassigned jrieken Jul 10, 2018
@chrmarti chrmarti added this to the July 2018 milestone Jul 10, 2018
@chrmarti
Copy link
Contributor

This was fixed a while ago.

@DanTup
Copy link
Contributor Author

DanTup commented Jul 10, 2018

Yep, works for me. Thanks :)

@sbatten sbatten added the verification-needed Verification of issue is requested label Aug 1, 2018
@roblourens roblourens added the verified Verification succeeded label Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
6 participants
@roblourens @bpasero @DanTup @jrieken @sbatten @chrmarti