Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS #regions folding #46591

Closed
octref opened this issue Mar 26, 2018 · 2 comments
Closed

CSS #regions folding #46591

octref opened this issue Mar 26, 2018 · 2 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Mar 26, 2018

Part of #45899

For example, when you have

/* #region */
.foo {
 color: red
}
/* #endregion */

You want to have the folding in it.

I don't think this feature is very helpful. Just to keep record of it.
If people do want it we can consider adding it.

@octref octref added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Mar 26, 2018
@octref octref added this to the Backlog milestone Mar 26, 2018
@octref octref self-assigned this Mar 26, 2018
@octref
Copy link
Contributor Author

octref commented Apr 11, 2018

@aeschli I fixed it only for comments using #region and #endregion. However in #47300 the screenshots show /* footer */. Should those be supported too or we only support #region and #endregion?

@aeschli
Copy link
Contributor

aeschli commented Apr 12, 2018

I'd say just #region and #endregion for now (there are requests to make that user configurable)

octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Apr 12, 2018
@aeschli aeschli modified the milestones: Backlog, April 2018 Apr 12, 2018
@sandy081 sandy081 added the verified Verification succeeded label Apr 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants