Search and replace across files corrupts files with CR line endings

[AArnott]

Issue Type: Bug

Execute these commands:

git clone https://github.com/AArnott/pinvoke.git
cd pinvoke
git checkout b1239bc075f87f202a410973d7faa468a5e6b9cf
code .

In the Search panel, search for "LICENSE.txt" and replace with "LICENSE" (no other options such as regex are selected).

In the search and replace results (before commiting them), notice how the second line of most source files has a small change applied. This is good.
But notice how 4 files have an erroneous change applied to the first line:

• src/User32/User32+DLGITEMTEMPLATE.cs
• src/User32/User32+DLGTEMPLATE.cs
• src/User32/User32+MSG.cs
• src/User32/User32+PeekMessageRemoveFlags.cs

VS Code version: Code 1.22.1 (950b8b0, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
Memory (System)	15.93GB (2.72GB free)
Process Argv	C:\Program Files\Microsoft VS Code\Code.exe .
Screen Reader	no
VM	0%

Extensions (16)

Extension	Author (truncated)	Version
vscode-markdownlint	Dav	0.14.1
githistory	don	0.4.0
xml	Dot	1.9.2
gitlens	eam	8.2.1
EditorConfig	Edi	0.12.1
git-project-manager	fel	1.5.1
docker-linter	hen	0.5.0
docomment	k--	0.0.18
azure-account	ms-	0.4.0
cpptools	ms-	0.16.1
csharp	ms-	1.14.0
PowerShell	ms-	1.6.0
team	ms-	1.133.0
vscode-docker	Pet	0.0.26
java	red	0.23.0
vsc-docker	Zim	0.34.0

[roblourens]

It looks like those files have CR-only line endings, which we don't support well: #35797

[AArnott]

How do line endings impact this? I'm not talking about how line endings may have been munged by the search and replace. I'm talking about how instead of replacing "LICENSE.txt" with "LICENSE", it replaced an entire line that didn't even include "LICENSE.txt" on it.

[roblourens]

The search tool doesn't consider them line endings, so it reports a match on line 1, and the editor clobbers the CR line endings, and things are out of sync... looking at the code again, I can handle it in a less destructive way, either by not reporting the match or not applying the replace.