Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict handling to documents with file: and untitled: schemes #48777

Closed
3 tasks done
octref opened this issue Apr 26, 2018 · 1 comment
Closed
3 tasks done

Restrict handling to documents with file: and untitled: schemes #48777

octref opened this issue Apr 26, 2018 · 1 comment
Assignees
@octref @mjbvz
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues markdown Markdown support issues verified Verification succeeded
Milestone
April 2018

Comments

@octref
Copy link
Contributor

octref commented Apr 26, 2018 •
edited by mjbvz
Loading

@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues markdown Markdown support issues labels Apr 26, 2018
@octref octref added this to the April 2018 milestone Apr 26, 2018
octref added a commit that referenced this issue Apr 26, 2018
@octref
Restrict html/css to only handling file and untitled files. Part of #…
0dfeec2 
…48777
@mjbvz mjbvz closed this as completed in 2864ccf Apr 26, 2018
@roblourens roblourens added the verified Verification succeeded label Apr 27, 2018
@kieferrm kieferrm mentioned this issue May 2, 2018
Closed
45 tasks
@aeschli
Copy link
Contributor

aeschli commented May 2, 2018 •
edited
Loading

@octref @kieferrm @egamma Why was this change made? Limiting the html selector breaks the PHP intelliphense extension (for HTML completions inside PHP) and all other use cases of virtual documents.

octref added a commit that referenced this issue May 2, 2018
@octref
Revert "Restrict html/css to only handling file and untitled files. P…
e4e7c25 
…art of #48777"

This reverts commit 0dfeec2.
octref added a commit that referenced this issue May 2, 2018
@octref
Revert "Restrict html/css to only handling file and untitled files. P…
76d4daa 
…art of #48777"

This reverts commit 0dfeec2.
@octref octref mentioned this issue May 2, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

@mjbvz mjbvz

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@roblourens @octref @aeschli @mjbvz