Command to open raw user settings.json, not in split view

[roblourens]

We have a setting to disable the settings split view, but it might be useful to have a command to open the user settings.json outside of the split view for a one-off.

From #41040 (comment)

[roblourens]

@usernamehw I am reverting the PR, it actually doesn't work. We intercept the editor open here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/common/preferencesContribution.ts#L83

[usernamehw]

Damn, it's already a part of my workflow 😢. What's wrong with it?

[roblourens]

So it opens the raw settings.json outside of the split view for you? For me, it actually just acts the same as the normal open settings command and opens the settings split view.

[roblourens]

And you don't have "workbench.settings.openDefaultSettings": false?

[usernamehw]

I don't have "workbench.settings.openDefaultSettings": false. The command itself works for me. Does it break some other functionality?

OS version: Windows_NT x64 10.0.17134

[usernamehw]

I see now. Opens a split view on linux VM. Was it ever working before on non-Windows environments?

[roblourens]

Yeah it only works on Windows, because the == check with fspath can fail due to drive letters being different. I guess that's a separate bug... I'll revert this tomorrow.

[roblourens]

We got a good bug out of this: #50760

[roblourens]

Now that the settings UI exists, I don't plan on investigating much more on the JSON editor. The split JSON UI will probably go away at some point (the JSON files themselves will always remain)

[usernamehw]

BUT I CAN'T OPEN JSON SETTINGS FILE (WITHOUT SPLIT) NOW AT ALL BECAUSE IT'S NOT LETTING ME.

Are you planning to allow users to see plain json file or to forbid it completely?

[roblourens]

We will always allow users to see the json file. Hopefully you can still open the raw json file with "workbench.settings.openDefaultSettings": false.

[usernamehw]

I know about that option, it's not great.

[roblourens]

I'll close this just because I am cleaning up issues that are specific to the JSON split editor. But to be clear, editing the JSON file will never go away :)