Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension API: Event when text editor is moved to another position/group #52068

Closed
jpoon opened this issue Jun 15, 2018 · 2 comments
Closed

Extension API: Event when text editor is moved to another position/group #52068

jpoon opened this issue Jun 15, 2018 · 2 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@jpoon
Copy link

jpoon commented Jun 15, 2018

vscodevim requires a unique ID for each editor. We are currently generating this ID based off of the document's filename and position (ie. viewColumn). However, we'd need to keep this ID up-to-date as the user moves the document to a new position.

As per @bpasero in #51001 (comment), the existing onDidChangeTextEditorViewColumn event only fires when:

* you move the group (containing all editors) to another position in the grid
* you close a group and as a result the position of other groups changes (e.g. close a group to the left of the current one)

We do not fire an event if you drag a single editor tab out of a group into another group. But this behaviour is totally unrelated to us moving to a grid model, it has always been like that for the reasons I mentioned earlier.

What I am requesting is an event that an extension can register on to be notified anytime an editor changes position in the grid.

@jrieken
Copy link
Member

jrieken commented Jun 18, 2018

/duplicate of #15178

@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 18, 2018
@vscodebot
Copy link

vscodebot bot commented Jun 18, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jun 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants