Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: API changes for grid editor layout #52315

Closed
2 tasks done
bpasero opened this issue Jun 19, 2018 · 0 comments
Closed
2 tasks done

Test: API changes for grid editor layout #52315

bpasero opened this issue Jun 19, 2018 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jun 19, 2018

Refs: #51001

Complexity: 3

There are some slight changes to the API to support grid editor layout. The ViewColumn is mapped onto the grid in a way that it represents the order of grid views in the grid (e.g. 1, 2, 3 for a 3 column layout from left to right, see docs). This is to stay compatible with how it used to be before when we only supported up to 3 columns. Verify:

  • Verify textEditor.viewColumn is always defined for an editor in the grid even if many are opened
  • Verify onDidChangeTextEditorViewColumn is fired when a group disappears to the left of the editor (so that its view column changes) or when moving a group to another location with drag and drop (drag the entire group, not just the tab!)
  • Verify ViewColumn.Beside can be used to always open an editor to the side (*)
  • Verify the vscode.setEditorLayout can be used to set an editor layout

(*): pull in our vscode.d.ts from master to get it

@bpasero bpasero added this to the June 2018 milestone Jun 19, 2018
@isidorn isidorn assigned sbatten, jrieken and roblourens and unassigned jrieken Jun 26, 2018
@roblourens roblourens removed their assignment Jun 26, 2018
@sbatten sbatten removed their assignment Jun 27, 2018
@sbatten sbatten closed this as completed Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants