Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Debugging from process explorer #64255

Closed
2 tasks done
RMacfarlane opened this issue Dec 3, 2018 · 3 comments
Closed
2 tasks done

Test: Debugging from process explorer #64255

RMacfarlane opened this issue Dec 3, 2018 · 3 comments

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Dec 3, 2018

Test for #63147

Complexity: 3

Adds a 'Debug' context menu item to node processes. If an --inspect, --inspect-brk, --debug, or --debug-brk flag is found (with or without port number), a debug session is started against a debug port. If none of the flags are found but the process executable is node a debug session is started via the process ID and the SIGUSR1 mechanism.

@jrieken
Copy link
Member

jrieken commented Dec 4, 2018

Works like a charm - would be even cooler if we can support electron_run_as_node and SIGUSR1

@jrieken jrieken removed their assignment Dec 4, 2018
@egamma egamma removed their assignment Dec 5, 2018
@egamma
Copy link
Member

egamma commented Dec 5, 2018

Nice!

It is also a convenient way to attach to a node process that you started from the built-in terminal with --inspect.
@weinand this should be documented in our docs as another way for how to debug a node progress.

@weinand
Copy link
Contributor

weinand commented Dec 5, 2018

@jrieken if we would stop using Electron's node and shipping an official node.js version, SIGUSR1 would work out of the box...

@egamma yep, makes sense, but I wonder how often regular users would want to open the "VS Code process explorer" to debug their own processes...

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants