Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't toggle comment with key binding @ linux mint 17.3 #6844

Closed
octohedron opened this issue May 24, 2016 · 1 comment
Closed

Can't toggle comment with key binding @ linux mint 17.3 #6844

octohedron opened this issue May 24, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@octohedron
Copy link

  • VSCode Version:

Version 1.1.1
Commit def9e32
Date 2016-05-13T13:38:00.094Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0

  • OS Version: Linux Mint 17.3

Steps to Reproduce:

  1. Plug in a Spanish keyboard (from Spain, pic below)
  2. Try to use the key-bindings to comment (Ctrl + /)

Description:
I'm trying to select text and comment it, which is "Ctrl + /" and it's giving me an info message "For your current keyboard layout press " Ctrl + - ", this is annoying since it's not what I need (Ctrl + /), it doesn't work, and it's also wrong, since "my keyboard layout" works fine (as in / is /) in every application and IDE (tested in more than 20 IDEs and text editors in more than 10 different operating systems)

btw, "/" is the numpad slash in my keyboard, the one on top of the numbers, to the right, not the one on top of the number 7.

This is the exact keyboard
image of DELL keyboard

key binding (same as default, but trying it anyways)

[
    { "key": "ctrl+/",          "command": "editor.action.blockComment",
                                     "when": "editorTextFocus" }
]

All I need is to set "comment block" or "comment line" to Ctrl + /, if I'm missing something, let me know.

@alexdima alexdima added keyboard-layout Keyboard layout issues keybindings VS Code keybinding issues bug Issue identified by VS Code Team member as probable bug labels Mar 2, 2017
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@alexdima alexdima added the linux Issues with VS Code on Linux label Mar 13, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in tomorrow's Insiders build) appear to behave correctly for this keyboard layout (at least on Ubuntu, but I believe we are fine on Linux Mint too)

image


Analysis of default keybinding for editor.action.commentLine

  • editor.action.commentLine is bound by default to the key code binding ctrl+/
  • / can be produced through one scan code combination: Shift+[Digit7]. i.e.:
    image
  • The key code binding ctrl+/ is therefore mapped to the scan code binding Ctrl+Shift+[Digit7] and the F1 command picker now correctly reflects that:
    image
    image
  • That is unfortunate, but correct. We don't ship with keyboard layout specific default keybindings, that is something you can upvote in Support contributing different keybindings based on keyboard layout #1240

This makes me believe the fix in PR #22894 aka #17521 resolves this issue. Please double check in tomorrow's insiders build.

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 23, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants