Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to save with UTF-8 + BOM encoding #751

Closed
kmpm opened this issue Nov 27, 2015 · 13 comments
Closed

Allow to save with UTF-8 + BOM encoding #751

kmpm opened this issue Nov 27, 2015 · 13 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@kmpm
Copy link

kmpm commented Nov 27, 2015

In version 0.10.2 I am having issues with making sure a file is saved with UTF-8 and BOM character encoding.

Please add such an option.

@bpasero bpasero added the feature-request Request for new features or functionality label Nov 27, 2015
@bpasero
Copy link
Member

bpasero commented Nov 27, 2015

👍

@bpasero
Copy link
Member

bpasero commented Nov 27, 2015

I mean 👍 for having such an option, but 👎 for any tool that needs BOMs :)

@bpasero bpasero removed their assignment Nov 27, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@bpasero bpasero added file-explorer Explorer widget issues and removed feature-request Request for new features or functionality labels Dec 18, 2015
@vilicvane
Copy link

@bpasero LOL, like powershell.

@bpasero
Copy link
Member

bpasero commented Jan 5, 2016

My strong position against BOMs is company agnostic ;)

@roslanr18
Copy link

.

@bpasero bpasero changed the title Need to save with UTF-8 + BOM encoding Allow to save with UTF-8 + BOM encoding Jan 6, 2016
@bpasero bpasero added the feature-request Request for new features or functionality label Jan 6, 2016
@bpasero bpasero removed their assignment Jan 6, 2016
@lv7777
Copy link

lv7777 commented Jan 17, 2016

I want to this feature too
👍

@iDiver76
Copy link

I really need this encoding type too. Is it planned in a future release?

@xavierclotet
Copy link

need too :[

@mgreenegit
Copy link
Member

Having this capability would unblock PowerShell Script Analyzer identifying a Warning for new scripts authored using VSCode.

Use BOM For Unicode Encoded File

@bpasero bpasero closed this as completed in c8dbbef Mar 3, 2016
@bpasero bpasero modified the milestones: March 2016, Backlog Mar 3, 2016
@bpasero bpasero self-assigned this Mar 3, 2016
@bpasero
Copy link
Member

bpasero commented Mar 3, 2016

Pushed a change that allows to set a new setting files.bom to one of:

  • preserve (default): keep any existing UTF-8 BOM, but not add it
  • insert: always add a UTF-8 BOM
  • remove: always remove any found UTF-8 BOM

@vilicvane
Copy link

👍

@bpasero
Copy link
Member

bpasero commented Mar 3, 2016

Discussed with the team and we favor a different approach that does not include a new setting, instead we piggy back on the existing encoding option and add a new option UTF8 with BOM. This has several advantages:

  • you can easily see if a file has a UTF 8 with BOM or not by looking at the status bar encoding info
  • you can actually convert a file between UTF 8 and UTF 8 with BOM by using the Save with Encoding action from the status bar picker and by picking UTF 8 to remove the BOM and the other to add it

@xavierclotet
Copy link

Now is better! you have to be able to save with BOM and save with BOM if the file already has it.

@egamma egamma mentioned this issue Mar 4, 2016
82 tasks
@bpasero bpasero added verified Verification succeeded and removed verified Verification succeeded labels Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants