Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command deprecation #8031

Closed
Tyriar opened this issue Jun 23, 2016 · 4 comments
Closed

Add command deprecation #8031

Tyriar opened this issue Jun 23, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 23, 2016

Instead of just changing command names, we should slowly phase them out and presenting warnings if the old ones are being relied upon and direct users to the new commands. Adjusting to #6605 (comment) may be easier that way, not totally destroying any custom keybindings and informing the user in a visible way of the change without the need to read the release notes.

This would also allow any clean up of command names to be done with a smaller impact to the end user.

@Tyriar Tyriar added the feature-request Request for new features or functionality label Jun 23, 2016
@bpasero
Copy link
Member

bpasero commented Jun 23, 2016

Actually maybe we could register all the old command ids and just show a message to the user telling him the new identifier of this command!

@bpasero bpasero added this to the June 2016 milestone Jun 23, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jun 23, 2016

Great! Something like that is what I had in mind 👍

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jun 27, 2016
@bpasero bpasero assigned Tyriar and unassigned bpasero Jun 27, 2016
@bpasero
Copy link
Member

bpasero commented Jun 27, 2016

@Tyriar assigning to you for verification.

image

@Tyriar Tyriar added the verified Verification succeeded label Jun 27, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jun 27, 2016

Thanks for putting this together!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants