Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab does not always gets revealed when activating it via keyboard #8398

Closed
alexdima opened this issue Jun 28, 2016 · 4 comments
Closed

Tab does not always gets revealed when activating it via keyboard #8398

alexdima opened this issue Jun 28, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Jun 28, 2016

Findings: the tabs widget currently does not detect when the underlying div scrolls. Need to listen for scrolling (e.g. caused by going through elements with tab and focussing them) and update the custom scrollbar accordingly.

Testing #7854

  • a lot of ctrl+m to get all editors move focus
  • shift-tab to reach the tab
  • space to select the tab
  • doing it with the mouse seems to always reveal it

vqzovjcrlg

@alexdima alexdima added the workbench-tabs VS Code editor tab issues label Jun 28, 2016
@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Weird, works for me on Mac at least.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2016
@bpasero bpasero added this to the June 2016 milestone Jun 28, 2016
@bpasero bpasero self-assigned this Jun 28, 2016
@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 29, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 Jun 29, 2016
@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

For me it even reveals the tab while I am tabbing through.

jun-29-2016 08-38-01

@alexdima
Copy link
Member Author

Sometimes it works, but maybe after clicking on them or selecting a few it stops working. I will try to see if I find what brings it in this state...

@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

Thanks!

@bpasero bpasero modified the milestones: June 2016, Backlog Jul 1, 2016
@bpasero bpasero removed the info-needed Issue requires more information from poster label Jul 1, 2016
@bpasero bpasero modified the milestones: July 2016, June 2016 Jul 1, 2016
@bpasero bpasero closed this as completed in 4a4c9ee Jul 4, 2016
@jrieken jrieken added the verified Verification succeeded label Jul 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

3 participants