Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Explorer: when there is only one view, split view should not be present #86037

Closed
isidorn opened this issue Dec 3, 2019 · 7 comments
Closed
Assignees
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality polish Cleanup and polish issue remote-explorer Remote explorer view

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2019

Refs: #85908

  1. Have a contributed view container like remote
  2. Hide all views except one
  3. That view is still shown in a split view. Instead it should be merged with the container (same as our vscode container behave, for example Explorer). It should no longer be inside a split view

This is also happening in Insiders
fyi @sandy081

@sandy081
Copy link
Member

sandy081 commented Dec 3, 2019

I think this is expected ad remote viewlet has special behaviour and is not merged.

@alexr00 Please confirm?

@alexr00
Copy link
Member

alexr00 commented Dec 3, 2019

That is correct, remote viewlet has special behavior and is not merged since the merging conflicts with the drop down.

@isidorn
Copy link
Contributor Author

isidorn commented Dec 3, 2019

I find that inconsistent - couldn't we merge the actions from the container with the actions of the view? Would there be too much?
Feel free to close as designed.

@alexr00
Copy link
Member

alexr00 commented Dec 3, 2019

Since the drop-down functions as a filter I think keeping the things it filters (views, including actions) below it it is clearer than having the title change and having actions move to be next to the drop-down. If we merge, it could look like those are top level actions and a top level title, which it is not. I will bring up at the next UX sync to get more input.

@alexr00 alexr00 assigned alexr00 and unassigned sbatten Dec 3, 2019
@alexr00 alexr00 added remote Remote system operations issues under-discussion Issue is under discussion for relevance, priority, approach labels Dec 3, 2019
@alexr00 alexr00 added this to the November 2019 milestone Dec 3, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Dec 3, 2019

That's makes sense, however since it is for a UX sync, we will probably not tackle it this week. Thus maybe assign to next milestone not this one?

@alexr00 alexr00 modified the milestones: November 2019, December 2019 Dec 3, 2019
@alexr00
Copy link
Member

alexr00 commented Jan 8, 2020

After UX discussion, this is the goal:
image
Then when there is only one view, the title still makes sense and there is room for the buttons.

@alexr00 alexr00 added polish Cleanup and polish issue remote-explorer Remote explorer view and removed remote Remote system operations issues under-discussion Issue is under discussion for relevance, priority, approach labels Jan 8, 2020
@alexr00 alexr00 changed the title Contributed view container: when there is only one view, split view should not be present Remote Explorer: when there is only one view, split view should not be present Jan 8, 2020
@alexr00 alexr00 modified the milestones: January 2020, February 2020 Jan 22, 2020
@alexr00
Copy link
Member

alexr00 commented Jan 22, 2020

Moving to February so that it will have more time in insiders for feedback.

@alexr00 alexr00 added this to the On Deck milestone Apr 23, 2020
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 9, 2020
@alexr00 alexr00 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Nov 10, 2021
@alexr00 alexr00 added the *as-designed Described behavior is as designed label Dec 13, 2023
@alexr00 alexr00 closed this as completed Dec 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality polish Cleanup and polish issue remote-explorer Remote explorer view
Projects
None yet
Development

No branches or pull requests

5 participants