Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I shouldn't be signed in automatically when launching vscode with a fresh user data dir #91482

Closed
roblourens opened this issue Feb 25, 2020 · 3 comments
Closed

I shouldn't be signed in automatically when launching vscode with a fresh user data dir #91482

roblourens opened this issue Feb 25, 2020 · 3 comments
Assignees
@RMacfarlane
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone
Backlog

Comments

@roblourens
Copy link
Member

Testing #91226

  • Sign in to Sync
  • Start vscode with a fresh userDataDir
  • Start Sync
  • I am already signed in and don't need to sign in again (but do need to enable sync)

Usually all the important pieces of information are in the userDataDir so this felt surprising. Discussed offline
@RMacfarlane RMacfarlane added the authentication Issues with the Authentication platform label Feb 25, 2020
@RMacfarlane
Copy link
Contributor

The only way I can think to fix this right now is by using globalStoragePath as part of the key when storing it in the keychain. I'm not sure if this would cause further issues (are there characters that aren't supported in the key?), so I'm going to wait and fix this in March

@RMacfarlane RMacfarlane added this to the March 2020 milestone Feb 27, 2020
@RMacfarlane RMacfarlane added feature-request Request for new features or functionality bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Feb 27, 2020
@roblourens
Copy link
Member Author

You could hash the path so you don't have to think about weird characters or very long keys

@RMacfarlane RMacfarlane modified the milestones: March 2020, April 2020 Apr 1, 2020
@RMacfarlane RMacfarlane modified the milestones: April 2020, Backlog Apr 27, 2020
@RMacfarlane RMacfarlane added feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code and removed bug Issue identified by VS Code Team member as probable bug labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RMacfarlane RMacfarlane

Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@roblourens @RMacfarlane and others