Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map-Type Setting Rendered as Header and List of Settings in Settings Editor UI #93598

Closed
savannahostrowski opened this issue Mar 27, 2020 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality settings-editor VS Code settings editor issues

Comments

@savannahostrowski
Copy link

savannahostrowski commented Mar 27, 2020

It would be great to have a map-type setting specified in settings.json rendered as a header and a list of name/descriptions and values in the Settings Editor UI.

Example:

There is a setting called "someGlobalSetting", which is an object. Both the keys and values have a list of permissible values.

{
"lang.someCategory.someGlobalSetting”: {
      “someName”: “someValue”,
      “someOtherName”: “somevalue”,
        …
    }
}

In the Settings Editor UI, the user would see some header (“someGlobalSetting”) and underneath it, they would see the keys and values mapped as a name/description (key) and an input mechanism (to select the value) as a list. In this case, it would be ideal if the input mechanism could be a dropdown for each key, value pair given that there are a fixed set of permissible values.

So the user could see something like:

Some Global Setting

someName dropdown of permissible values
someOtherName dropdown of permissible values
...

@roblourens
Copy link
Member

It's true that we don't get intellisense for the array control in the nice way that we do for the json editor. One possible issue with this approach is that you wouldn't control the order, is that a problem?

So then a generic control for a type like

"someSetting": {
  "hey": true,
  "there": false
}

might be better

@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Mar 28, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Mar 28, 2020
@vscodebot
Copy link

vscodebot bot commented Mar 28, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@savannahostrowski
Copy link
Author

savannahostrowski commented Mar 30, 2020

@roblourens That's a good question and a good catch. In my particular case, having the ability to keep the settings in a consistent order and control what order they appear in would be nice.

@savannahostrowski savannahostrowski changed the title Render an Array of Pre-Defined Strings as a List of Checkboxes in Settings Editor UI Map-Type Setting Rendered as Header and List of Settings in Settings Editor UI Apr 19, 2020
@savannahostrowski
Copy link
Author

@roblourens The requirements for this have changed. As such, I've updated this ticket.

@9at8
Copy link
Member

9at8 commented Jun 8, 2020

Tracking everything related to the new renderer in #99635

@roblourens
Copy link
Member

Closed with #99635

@roblourens roblourens removed this from the Backlog milestone Aug 10, 2020
@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @9at8 @savannahostrowski and others