Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit notebook cell uris #97881

Closed
jrieken opened this issue May 15, 2020 · 2 comments
Closed

Revisit notebook cell uris #97881

jrieken opened this issue May 15, 2020 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality notebook on-release-notes Issue/pull request mentioned in release notes on-testplan uri
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented May 15, 2020

Today, notebook cell have the following URI format

vscode-notebook-cell://<notebook-authority>/<notebook-path>, cell <handle>?<payload>

This makes then

  • render in the UI like some/path/someNotebook.foo, cell 12
  • makes a cell a different resource - by the rules of URI

The downsides are

  • The cell handle appears in the UI and that's something users can not really relate to
  • A cell is inside the notebook, not a different resource, using fragments is the better fit
  • Grouping is often (but not always) bogous (see screen shot below)

Screenshot 2020-05-15 at 12 38 57

The plan is to use a URI format for notebook cells that do not make them appear as separate things but make them appears as the notebook itself

@jrieken jrieken self-assigned this May 15, 2020
@jrieken jrieken added feature-request Request for new features or functionality notebook uri labels May 15, 2020
@jrieken jrieken added this to the Backlog milestone May 15, 2020
jrieken added a commit to microsoft/vscode-references-view that referenced this issue May 15, 2020
jrieken added a commit to microsoft/vscode-references-view that referenced this issue May 15, 2020
@jrieken
Copy link
Member Author

jrieken commented May 15, 2020

🧑‍🏭 work in progress 🧑‍🏭

I have changed the peek model and the references viewlet to group resources independent of their uri-fragment, e.g foo:///bar#a and foo:///bar#b are different uris pointing to the same resource. It actually works nice for those two, but I am unsure about diagnostics: there we don't show a preview but line/character, e.g. [2, 1], which only make sense in the scope of a resource. The screen shot below might be confusing because

Screenshot 2020-05-15 at 16 07 29

@jrieken
Copy link
Member Author

jrieken commented May 27, 2020

This did happen 👯

@jrieken jrieken closed this as completed May 27, 2020
@jrieken jrieken added on-testplan on-release-notes Issue/pull request mentioned in release notes labels May 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook on-release-notes Issue/pull request mentioned in release notes on-testplan uri
Projects
None yet
Development

No branches or pull requests

1 participant