Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the source tab when dragging to another window #9915

Closed
Tyriar opened this issue Jul 28, 2016 · 4 comments
Closed

Close the source tab when dragging to another window #9915

Tyriar opened this issue Jul 28, 2016 · 4 comments
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-tabs VS Code editor tab issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 28, 2016

  • VSCode Version: Code - Insiders 1.4.0-insider (531a56f, 2016-07-28T16:52:53.252Z)
  • OS Version: Linux x64 4.4.0-31-generic, Ubuntu 16.04

Steps to Reproduce:

  1. Open two vscode windows
  2. Open a file tab
  3. Drag the tab to the other window, notice the original file is still open after the drag and drop action
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench workbench-tabs VS Code editor tab issues labels Jul 28, 2016
@Tekbr
Copy link

Tekbr commented Jul 29, 2016

  • VSCode Version: 1.4.0-insider commit 4656fe3 2016-07-29T05:08:49:671Z
  • OS Version: Windows 10

-- Sorry for the English, I used Google Translator --

1- Allow files "not saved" - "Untitled-1". They are moved to new windows, not only files and have already been saved.

2- So there is no conflict between the files, remove the number from "Untitled", or automatically rename to new sequence numbers when we moved to a new window that has the "Untitled -'x '."

3- By dragging the tab out of the tab bar to open in a new window. This is not possible.

new-window

@bpasero bpasero changed the title Drag and drop into another window should close the source editor Close the source tab when dragging to another window Aug 6, 2016
@bpasero bpasero added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Aug 6, 2016
@bpasero bpasero added this to the Backlog milestone Aug 6, 2016
@bpasero
Copy link
Member

bpasero commented Aug 6, 2016

This may require quite a bit of work to find out that the drop happened outside of the window, I am not sure this can be easily detected but I can give it a quick try.

@bpasero bpasero modified the milestones: August 2016, Backlog Aug 6, 2016
@bpasero
Copy link
Member

bpasero commented Aug 8, 2016

I could not find a solution to detect that you drop outside of the window other than maybe looking at the X/Y coordinates and then checking if they are within the window, which is super ugly. Given that, I think I would rather not want to add this until there is real support for better cross-window DND.
Also: this does not help with the case where the drop operation was not successful on the target. I think the real solution would be to somehow include the originating window in the dragged URI and in the target window send a IPC message over to the source if the drop was OK and only then close the editor.

@bpasero bpasero modified the milestones: Backlog, August 2016 Aug 8, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 8, 2016
@bpasero bpasero removed their assignment Aug 17, 2016
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Aug 29, 2016
@bpasero bpasero removed workbench help wanted Issues identified as good community contribution opportunities labels Nov 16, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 17, 2017
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Sep 18, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 18, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

3 participants