Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid absolute path in pinned dynamic config #99308

Closed
roblourens opened this issue Jun 3, 2020 · 1 comment
Closed

Avoid absolute path in pinned dynamic config #99308

roblourens opened this issue Jun 3, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

Verifying #95836

We should try to resolve these to some form of ${workspaceFolder} if possible, so I can check this in without fixing it.

image

@connor4312 connor4312 added this to the May 2020 milestone Jun 3, 2020
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Jun 3, 2020
@connor4312
Copy link
Member

connor4312 commented Jun 5, 2020

To verify:

  • Make sure you're on the latest js-debug nightly, 2020.6.417. You may need to grab the vsix from the marketplace manually since it's built-in.
  • In some workspace with package.json scripts ctrl + p and enter debug node.js
  • Hover one of the scripts in the quickpick that comes up and click on the gear icon
  • This saves that config to the launch.json. Verify that the cwd is set with the ${workspaceFolder} in the launch.json

@JacksonKearl JacksonKearl added the verified Verification succeeded label Jun 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants