Notebook opens as text/plain after reload + click

[joaomoreno]

1. Open notebook
2. Reload
3. While it loads, click the notebook in the file explorer

🐛 Notebook opens as text/plain.

[rebornix]

I can reproduce this issue with Image Editor too. The root cause is when we click the file from file explorer after reloading the workspace, the editoroverrides are not registered yet, which will then open the document in text editor.

[rebornix]

Actually I was wrong, we registered editoroverrides very early on. The root cause is group view listeners are registered only when groups are all restored

vscode/src/vs/workbench/services/editor/browser/editorService.ts

Line 92 in f17030d

this.editorGroupService.whenRestored.then(() => this.onEditorsRestored());

and only when the group view listeners are registered, editor overrides will be called

vscode/src/vs/workbench/services/editor/browser/editorService.ts

Lines 164 to 166 in f17030d

	groupDisposables.add(group.onWillOpenEditor(event => {
	this.onGroupWillOpenEditor(group, event);
	}));

I'm wondering if we can register those event listeners a bit earlier, for example, register after the groups are created from EditorPart#doCreateGridControl https://github.com/microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editorPart.ts#L929, instead of waiting for the groups fully resolved. @bpasero @isidorn any suggestions?

[bpasero]

@rebornix yes looks like the overrides need to register early, but the problem is that the groups only restore as part of the startup, so you cannot register listeners without knowing which groups are there.

I think again, this way of overrides is full of issues and #100281 discusses an alternative where you register an override statically that will kick in very early in the createInput of things. If you have energy to drive this change and adopt it for notebooks, please go ahead.

[rebornix]

Moving this out of June and the polish should happen with #100281. Discussions and proposals will continue there.

[mjbvz]

I believe this has been fixed by @lramos15's recent work. Assigning to May for verification