Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow language server hovers to be displayed while in a debug session #99856

Closed
DanTup opened this issue Jun 11, 2020 · 6 comments
Closed

Allow language server hovers to be displayed while in a debug session #99856

DanTup opened this issue Jun 11, 2020 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@DanTup
Copy link
Contributor

DanTup commented Jun 11, 2020

When debugging, hovering over a class name sends the request to the debugger for evaluation, and not to the language server. This is a bit awkward if you want to read the documentation for a type that's in the code you're debugging.

This was briefly discussed at #48747 (comment) but I was asked about it again and it looks like there's no open issue tracking it.

This seems like really useful functionality - even if Code can't render multiple tooltips, being able to hold down a modifier or something to get the language tooltip while debugging would be nice.

@isidorn
Copy link
Contributor

isidorn commented Jun 12, 2020

For now forwarding to @weinand as he looked into debug adapter language server integration and might have more details

@isidorn isidorn assigned weinand and unassigned isidorn Jun 12, 2020
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 12, 2020
@weinand weinand added this to the On Deck milestone Jun 12, 2020
@weinand weinand added the feature-request Request for new features or functionality label Jun 12, 2020
@Trass3r
Copy link

Trass3r commented Aug 26, 2020

True, VS has the same limitation.

@weinand
Copy link
Contributor

weinand commented Aug 26, 2020

@isidorn I like the idea of using a modifier key to switch between debug hover and language hover.
This approach does not need any additional integration between debug and language services.

@Trass3r
Copy link

Trass3r commented Aug 26, 2020

Special case of #102939?

@isidorn
Copy link
Contributor

isidorn commented Aug 26, 2020

I also like that idea. Let me assign to September so I can investigate more then.

@isidorn isidorn modified the milestones: On Deck, September 2020 Aug 26, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 26, 2020

Let's close as dup of #84561
Thanks @Trass3r for pointing out

@isidorn isidorn closed this as completed Aug 26, 2020
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 26, 2020
@isidorn isidorn removed the feature-request Request for new features or functionality label Sep 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants