Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for resolving code actions #106856

Merged
merged 5 commits into from
Sep 18, 2020
Merged

Support for resolving code actions #106856

merged 5 commits into from
Sep 18, 2020

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Sep 16, 2020 •
edited
Loading

This PR fixes #106410 by adding proposed API to resolve code actions. Changes in summary

  • Adds CodeActionItem-object which hold a modes.CodeAction and its provider. This change has a big, but also straight-forward, ripple
  • Adds cache id to code action DTO, using the already existing cache
  • Updates the existing API command to allow to spec the number of items that should be resolved

@jrieken
Add resolveCodeAction to internal API, introduce CodeActionItem which…
9813ffd 
… knows a CodeAction and the provider, adopt CodeActitemItem in codeAction-land
@jrieken
proposed API for CodeActionProvider#resolveCodeAction and all the wiring
136cc27
@jrieken
Allow executeCodeActionProvider API command to set the number of item…
f8ad845 
…s to resolve, unit test to check that and the whole resolve machinery
@jrieken jrieken self-assigned this Sep 16, 2020
@jrieken jrieken added this to the September 2020 milestone Sep 16, 2020
@jrieken jrieken mentioned this pull request Sep 16, 2020
Closed
@jrieken jrieken requested a review from mjbvz September 17, 2020 07:07
mjbvz
mjbvz approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and API look good to me

@jrieken jrieken merged commit c1472bd into master Sep 18, 2020
@jrieken jrieken deleted the joh/resolveCodeAction branch September 18, 2020 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.

Support to resolve code actions
2 participants
@jrieken @mjbvz