Adopt WCO for Windows #147947
Adopt WCO for Windows #147947
Conversation
sbatten
added
titlebar
There was a problem hiding this comment.
Pretty cool 👍
I see a bit of flicker when updating the theme, where first the WCO changes and then the workbench. Is there a way to set the WCO transparent so that we do not have to change its color and simply get the color of the title bar without having to update the WCO color?
I also see a border below the WCO when window is maximized:
Clicking minimize button and then restore, does not clear the button hover style for me:
PS: I did not review he CSS changes or changes in titlebarPart.ts because you are the expert in those by now.
src/vs/workbench/electron-sandbox/parts/titlebar/titlebarPart.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/contextmenu/electron-sandbox/contextmenuService.ts
Show resolved
Hide resolved
|
@bpasero responded to feedback and made some changes.
Unfortunately no, a transparent control actually shows a native color (that pale blue from windows aero days)
I wasn't able to repro this one. Are you in a VM?
I can repro this one @deepak1556 |
|
Yes I am on a VM and typically have zoom level of 1 in VSCode. |
| .monaco-workbench.web .part.titlebar > .titlebar-container, | ||
| .monaco-workbench.windows .part.titlebar > .titlebar-container, | ||
| .monaco-workbench.linux .part.titlebar > .titlebar-container { | ||
| .monaco-workbench.web .part.titlebar>.titlebar-container, |
There was a problem hiding this comment.
Any reason you changed the style here? We typically have whitespace around >
There was a problem hiding this comment.
some formatter I have has been doing this on occasion. and I just recently found that I had the setting which only applies this to changed regions
There was a problem hiding this comment.
Can we revert that as part of sbatten/outdoor-mosquito maybe? I prefer the old style.
| display: flex; | ||
| .monaco-workbench.mac .part.titlebar>.window-controls-container { | ||
| width: 70px; | ||
| height: env(titlebar-area-width, 28px); |
There was a problem hiding this comment.
I wonder why this was added? Are we using WCO on macOS?
This PR
fixes #136132
fixes #127449
cc @deepak1556