Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to reverse the sort order in explorer #149952

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

lioman
Copy link
Contributor

@lioman lioman commented May 19, 2022

  • add option to settings
  • adapt interfaces
  • reverse sort order in FileSorter if option is set

This PR fixes #149951

- add option to settings
- adapt interfaces
- reverse sort order in FileSorter if option is set

Signed-off-by: Lioman <dev@lioman.de>
@ghost
Copy link

ghost commented May 19, 2022

CLA assistant check
All CLA requirements met.

@lioman
Copy link
Contributor Author

lioman commented Oct 10, 2022

Any news on that @lramos15 - can I help to push this through?

@lioman
Copy link
Contributor Author

lioman commented Mar 1, 2023

This pr ist now some time Open. IT would really help, if one could reverse the order.

Is something still blocking a merge?

@lramos15
Copy link
Member

lramos15 commented Mar 1, 2023

Not sure we want to add a third sort option, maybe this could go under explorer.sortOrder. Also we get a lot of sort option requests in general so not sure if we will be taking this in or investigating ways for extensions to provide sort orders to help cover everyone's needs.

@lioman
Copy link
Contributor Author

lioman commented Mar 1, 2023

@lramos15 I think it is a bit different here. This wan is not a third option, but one to reverse any set order. I think about this as clicking on the order columns in an email client. Sometimes you need the oldest one first, sometimes the other way round. Currently, vscode has only an option to ORDER BY but you can't switch between ASC and DESC

@lramos15
Copy link
Member

lramos15 commented Mar 1, 2023

Yes but I wonder if we should just do Sort order as one option and then Sort order - reverse as the other. Basically doubling the list instead of having a third option, I'm not sure. The downside being that will grow the list quite a bit.

@lioman
Copy link
Contributor Author

lioman commented Mar 1, 2023

That doesn't sound better to me. For two reasons: List is doubled in size and more important, every change needs to be maintained in two entries.
So if there is a new option, the reverse one must always be added too.

@lramos15
Copy link
Member

lramos15 commented Mar 1, 2023

Yeah that makes sense. I still wish there was an easy way for extensions to contribute sort order since we get a lot of sort asks in general and cannot maintain them all.

@lramos15 lramos15 added this to the On Deck milestone Mar 1, 2023
Copy link

@id-ekaagr id-ekaagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring your attention here, for some dev this is a must have feature and this "reverse sort order in explorer" is not even a big ask.

@lioman
Copy link
Contributor Author

lioman commented Oct 30, 2023

This would be really valuable and a small change. Is there anything I can do to support this change @lramos15

@microsoft microsoft deleted a comment from id-aditya Jul 30, 2024
@lramos15
Copy link
Member

Thanks for the contribution @lioman. And thanks for being patient. I was trying to debate better ways to do this as it opens the door to 100 other sort feature requests that we will have to maintain, but I understand the want for a simple reverse and don't want to continue to hold this feature back.

@lramos15 lramos15 merged commit 8a5c01c into microsoft:main Jul 30, 2024
6 checks passed
@lioman lioman deleted the reverse-file-explorer-sort-order branch August 1, 2024 06:36
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse sort order in explorer
6 participants